Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce extension uniqueness #155

Open
cpu opened this issue Sep 10, 2023 · 0 comments
Open

Enforce extension uniqueness #155

cpu opened this issue Sep 10, 2023 · 0 comments

Comments

@cpu
Copy link
Member

cpu commented Sep 10, 2023 •
edited
Loading

As a breaking API change rcgen should refuse to generate certificates with duplicate extensions.

RFC 5280 §4.2 says:

A certificate MUST NOT include more than one instance of a particular extension.

This can occur with the current API in two ways:

  1. Specifying duplicate extensions within CertificateParams.custom_extensions
  2. Specifying an extension in CertificateParams.custom_extensions that has the same OID as an extension rcgen emits natively (e.g. id-ce-subjectAltName, id-ce-authorityKeyIdentifier, etc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wip: refactoring extension handling cpu/rcgen
1 participant
@cpu