Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic on prune #239

Closed
bjo81 opened this issue Aug 10, 2024 · 2 comments
Closed

panic on prune #239

bjo81 opened this issue Aug 10, 2024 · 2 comments
Labels
A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected I-panic S-triage Status: Waiting for a maintainer to triage this issue/PR

Comments

@bjo81
Copy link

bjo81 commented Aug 10, 2024

Hi,
thanks for #235 , got a new crash now:

name = "rustic-rs"
operating_system = "Arch Linux [64-bit]"
crate_version = "0.7.0-dev"
explanation = """
Panic occurred in file '/data/build/.cargo/git/checkouts/rustic_core-fa42f42e094d79df/1cecce8/crates/core/src/blob/tree.rs' at line 690
"""
cause = 'called `Result::unwrap()` on an `Err` value: "SendError(..)"'
method = "Panic"
backtrace = """

   0: 0x61ebd4d5e1da - <unresolved>
   1: 0x61ebd4d5b7c7 - <unresolved>
   2: 0x61ebd4ffa9cb - <unresolved>
   3: 0x7335ac51839d - <unresolved>
   4: 0x7335ac59d49c - <unresolved>
   5:        0x0 - <unresolved>"""
@github-actions github-actions bot added the S-triage Status: Waiting for a maintainer to triage this issue/PR label Aug 10, 2024
@zhuxiujia
Copy link

code have many .unwrap(); on 45 matches on 15 files.
I suggest the author should handle these possible exceptions，may make it more stable

simonsan added a commit that referenced this issue Oct 5, 2024
@simonsan
fix(errors): add error logging when sending tree from backend
6ea6932 
Fixes #239

Signed-off-by: simonsan <[email protected]>
@simonsan simonsan mentioned this issue Oct 5, 2024
Merged
@simonsan simonsan added A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected I-panic labels Oct 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 9, 2024
@simonsan
refactor(errors): improve message and add logging when sending tree f…
428fa7a 
…rom backend panics (#314)

Related #239
Related #209

---------

Signed-off-by: simonsan <[email protected]>
@simonsan
Copy link
Contributor

simonsan commented Oct 9, 2024

Closing as duplicate of #209

@simonsan simonsan closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
@simonsan simonsan mentioned this issue Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-errors Area: error handling needs improvement C-bug Category: Something isn't working as expected I-panic S-triage Status: Waiting for a maintainer to triage this issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bjo81 @zhuxiujia @simonsan