Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agenda requests frequently fail due to rfcbot deserialization error #1886

Open
ehuss opened this issue Jan 23, 2025 · 3 comments
Open

agenda requests frequently fail due to rfcbot deserialization error #1886

ehuss opened this issue Jan 23, 2025 · 3 comments
Assignees
Labels
A-agenda-generator Area: lang team agenda generator bug Something isn't working

Comments

@ehuss
Copy link
Contributor

ehuss commented Jan 23, 2025

I see this in the log messages fairly regularly:

2025-01-23T03:13:51.175570Z ERROR request{uuid=5d48bb64-23a8-4ade-ab7f-ec99ff3290ab}: triagebot: agenda request failed: Unable to get all fcps from rfcbot.
Caused by:
    0: error decoding response body: invalid value: integer `2490321401`, expected i32 at line 1 column 10826
    1: invalid value: integer `2490321401`, expected i32 at line 1 column 10826

I vaguely recall @Mark-Simulacrum doing some trickery to try to fix the i32 overflow on the rfcbot, but I don't remember the details. Does triagebot's type need to be changed to something else?

@ehuss ehuss added bug Something isn't working A-agenda-generator Area: lang team agenda generator labels Jan 23, 2025
@apiraino
Copy link
Contributor

I think that was me today using an unpatched version of the t-compiler triage agenda generator. There is indeed an issue (after what happened with the GH incremental ID) but I am usually using a locally patched version with the issue fixed.

I'm sorry I didn't yet get around pushing it here, I just need to do that.

@rustbot claim

@Mark-Simulacrum
Copy link
Member

I think I fixed all of the api endpoints to return the right (u64) types from rfcbot - maybe I missed one? Or, actually, that error looks like the triagebot side is wrong - we should be expecting a u64, not i32.

@apiraino happy to tweak rfcbot further if I did miss something on that side.

@apiraino
Copy link
Contributor

For my reference: I think this patch will fix more stuff but I need to look at it again before opening a PR here 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-agenda-generator Area: lang team agenda generator bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants