Skip to content

Commit 60c2593

Browse files
authored
Merge pull request #1913 from Noratrieb/relnotes
Fix relnotes template arguments
2 parents 2bbb8b6 + 7ae8646 commit 60c2593

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/handlers/relnotes.rs

+8-6
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ pub async fn handle(ctx: &Context, event: &Event) -> anyhow::Result<()> {
7373
let title = format!("{TITLE_PREFIX} of #{}: {}", e.issue.number, e.issue.title);
7474
let body = format!(
7575
"
76-
This issue tracks the release notes text for #{}.
76+
This issue tracks the release notes text for #{pr_number}.
7777
78-
cc {} -- original issue/PR authors and assignees for drafting text
78+
cc {people} -- original issue/PR authors and assignees for drafting text
7979
8080
See the forge.rust-lang.org chapter about [release notes](https://forge.rust-lang.org/release/release-notes.html#preparing-release-notes) for an overview of how the release team makes use of these tracking issues.
8181
@@ -88,7 +88,7 @@ This section should be edited to specify the correct category(s) for the change,
8888
8989
````markdown
9090
# Language/Compiler/Libraries/Stabilized APIs/Const Stabilized APIs/Rustdoc/Compatibility Notes/Internal Changes/Other
91-
- [{}]({})
91+
- [{pr_title}]({pr_url})
9292
````
9393
9494
> [!TIP]
@@ -106,9 +106,11 @@ If this change is notable enough for inclusion in the blog post then this sectio
106106
>
107107
> If a blog post section is required the `release-blog-post` label should be added (`@rustbot label +release-blog-post`) to this issue as otherwise it may be missed by the release team.
108108
",
109-
e.issue.number, e.issue.title, e.issue.html_url,
110-
[&e.issue.user].into_iter().chain(e.issue.assignees.iter())
111-
.map(|v| format!("@{}", v.login)).collect::<Vec<_>>().join(", ")
109+
pr_number = e.issue.number,
110+
people = [&e.issue.user].into_iter().chain(e.issue.assignees.iter())
111+
.map(|v| format!("@{}", v.login)).collect::<Vec<_>>().join(", "),
112+
pr_title = e.issue.title,
113+
pr_url = e.issue.html_url,
112114
);
113115
let resp = ctx
114116
.github

0 commit comments

Comments
 (0)