-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make drop-glue/destructor hover tooltip more compact and distinguishable #19410
Comments
We deliberately choose "does not contain types with destructors" because some people may not know what drop glue means, Although I'm not a fan of the wording, I couldn't find anything better. |
At least among the rust codebases and programmers I've interacted with "Drop" is the word used (not destructor, though that is how the feature is documented: https://doc.rust-lang.org/reference/destructors.html, and may be more familiar to users of languages other than rust). I strongly agree with trying to put this in the meta-data line instead of blending with the documentation. How about |
This reduces the amount of information shown (a direct `Drop` impl is rendered the same way as the drop glue that calls `Drop` impls transitively), but I don't know of a scenario where the difference is meaningful. Closes rust-lang#19410
This reduces the amount of information shown (a direct `Drop` impl is rendered the same way as the drop glue that calls `Drop` impls transitively), but I don't know of a scenario where the difference is meaningful. Closes rust-lang#19410
This reduces the amount of information shown (a direct `Drop` impl is rendered the same way as the drop glue that calls `Drop` impls transitively), but I don't know of a scenario where the difference is meaningful. Closes rust-lang#19410
This combines the memory layout and drop information on one line, and makes the wording more succinct. Closes rust-lang#19410
#18987 added a feature to show information about a type's drop glue and destructor in the hover tooltip.
This information is useful enough that I don't want to turn the feature off, but in practice I find that it:
It might be preferable to do some or all of these, by default or as an option:
The text was updated successfully, but these errors were encountered: