You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pin-utils::pin_mut has been deprecated in favor of core lib's core::pin::pin! since 1.68. However, the semantic of pin_mut is subtly different from pin. IIUC -
let object = ...;pin_mut!(object);// is equal tolet object = ...;let object = pin!(object);
(and pin_mut! support pin multiple values)
I wonder if we can drop reexport pin_mut macro so that we don't depend on a deprecated lib in the next breaking release (0.4), or we should wrap a pin_mut! based on core::pin::pin:
I think it is reasonable to remove it in v0.4, but I don't think v0.3 will do anything since dropping it is a breaking change. However, it may be okay to inline it to remove dependency on pin-utils.
Currently, futures-util reexport
pin_utils::pin_mut!
and it is reexported in the facade futures also:futures-rs/futures-util/src/lib.rs
Line 26 in 048995a
futures-rs/futures/src/lib.rs
Line 122 in 048995a
pin-utils::pin_mut
has been deprecated in favor of core lib'score::pin::pin!
since 1.68. However, the semantic ofpin_mut
is subtly different frompin
. IIUC -(and
pin_mut!
support pin multiple values)I wonder if we can drop reexport pin_mut macro so that we don't depend on a deprecated lib in the next breaking release (0.4), or we should wrap a
pin_mut!
based oncore::pin::pin
:Or we just do nothing and keep the current code forever?
Another related question is whether we could replace
futures_core::ready!
withcore::task::ready!
when the MSRV is bumped beyond 1.64.cc @taiki-e since we have related discussions at #2901 and on zulip.
The text was updated successfully, but these errors were encountered: