Skip to content

Commit 160ef45

Browse files
authored
Merge pull request #54 from ndmitchell/fix-53
Remove parsing of __ in title strings, fixes #53
2 parents a620165 + ee4687b commit 160ef45

File tree

2 files changed

+9
-30
lines changed

2 files changed

+9
-30
lines changed

src/display_list/from_snippet.rs

+5-16
Original file line numberDiff line numberDiff line change
@@ -53,22 +53,11 @@ fn format_label(
5353
) -> Vec<DisplayTextFragment<'_>> {
5454
let mut result = vec![];
5555
if let Some(label) = label {
56-
for (idx, element) in label.split("__").enumerate() {
57-
let element_style = match style {
58-
Some(s) => s,
59-
None => {
60-
if idx % 2 == 0 {
61-
DisplayTextStyle::Regular
62-
} else {
63-
DisplayTextStyle::Emphasis
64-
}
65-
}
66-
};
67-
result.push(DisplayTextFragment {
68-
content: element,
69-
style: element_style,
70-
});
71-
}
56+
let element_style = style.unwrap_or(DisplayTextStyle::Regular);
57+
result.push(DisplayTextFragment {
58+
content: label,
59+
style: element_style,
60+
});
7261
}
7362
result
7463
}

tests/dl_from_snippet.rs

+4-14
Original file line numberDiff line numberDiff line change
@@ -262,20 +262,10 @@ fn test_format_label() {
262262
annotation: dl::Annotation {
263263
annotation_type: dl::DisplayAnnotationType::Error,
264264
id: None,
265-
label: vec![
266-
dl::DisplayTextFragment {
267-
content: "This ",
268-
style: dl::DisplayTextStyle::Regular,
269-
},
270-
dl::DisplayTextFragment {
271-
content: "is",
272-
style: dl::DisplayTextStyle::Emphasis,
273-
},
274-
dl::DisplayTextFragment {
275-
content: " a title",
276-
style: dl::DisplayTextStyle::Regular,
277-
},
278-
],
265+
label: vec![dl::DisplayTextFragment {
266+
content: "This __is__ a title",
267+
style: dl::DisplayTextStyle::Regular,
268+
}],
279269
},
280270
source_aligned: true,
281271
continuation: false,

0 commit comments

Comments
 (0)