Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance being replaced even when the machine_image is pinned #114

Open
kpocius opened this issue May 15, 2023 · 3 comments · May be fixed by #149
Open

Instance being replaced even when the machine_image is pinned #114

kpocius opened this issue May 15, 2023 · 3 comments · May be fixed by #149
Labels
needs-triage Waiting for first response or review from a maintainer

Comments

@kpocius
Copy link
Contributor

kpocius commented May 15, 2023

machine_image pinning was introduced in #112 but even with the value set, the instance is being replaced when a new COS image comes out.

I believe the issue is in the locals:

  labels               = merge(var.labels, { "container-vm" = module.container.vm_container_label })

Didn't have time to dig into it, but I believe if we want to pass the correct label to the module, we need to parse machine_image. Alternatively we should update the way local.labels is generated.

Just raising an issue, in case someone wants to take a look. Might dig into it myself when I have a moment.

@kpocius
Copy link
Contributor Author

kpocius commented May 26, 2023

@bschaatsbergen, this must have been a fluke -- I can no longer replicate the issue. Sorry for raising false alarms.

@kpocius kpocius closed this as completed May 26, 2023
@bschaatsbergen
Copy link
Member

Ah check, happy to see that it's not reproducible 😬 @kpocius

@dimisjim dimisjim linked a pull request Apr 18, 2024 that will close this issue
@dimisjim
Copy link

dimisjim commented Apr 18, 2024

I think we need to reopen this. I am still experiencing this problem, which relates to the labels that are not properly pinned for the disks, even though machine_image is set as an input variable to the module.

The way I fixed it was with these changes: #149

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Waiting for first response or review from a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants