Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the ability to deploy Atlantis without a domain associated to it #100

Open
JSNortal opened this issue Feb 22, 2023 · 3 comments
Open

Comments

@JSNortal
Copy link

It would be useful to make the domain input optional to and allow for the module to either reserve a static external IP or take as an input.

It would make getting up and running a bit faster for testing purposes.

@bschaatsbergen
Copy link
Member

bschaatsbergen commented Feb 22, 2023

@JSNortal thanks for taking the time to raise this issue 👍🏼
What are your thoughts on this? @kpocius

@kpocius
Copy link
Contributor

kpocius commented Feb 22, 2023

Sounds doable, although I'd keep the reservation out of the scope of the module, much like it is now done with DNS records. Also, this needs to come with proper warnings that some potential security features will be lost (e.g. I don't see this setup working with IAP).

@steliossid
Copy link

Is it possible to use a reserved external static IP in GCP as the domain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants