v0.22.3: PR comment shows "apply" even if "apply" is omitted from allow-commands

[leewilmott]

I hope someone can help.

Today I setup Atlantis v0.22.3 in a test environment so that I can play with it. I am using BitBucket Server.

I believe I have it working and all is good.

That being said I have configured Atlantis to only allow the "version and plan" commands by setting the following environment variable...

ATLANTIS_ALLOW_COMMANDS=version,plan

...I have also added my BitBucket environment variables and a repo-config.

I believe that the "ATLANTIS_ALLOW_COMMANDS" variable is working because when I comment on the PR with "atlantis apply -d ." it says...

Error: unknown command "apply".
Run 'atlantis --help' for usage.
Available commands(--allow-commands): version, plan

If I then comment "atlantis plan" on an existing PR, Atlantis runs and comments on my PR. The Atlantis comment reads...

• To apply this plan, comment:
  • atlantis apply -d .
• To delete this plan click here
• To plan this project again, comment:
  • atlantis plan -d .

...

• To apply all unapplied plans from this pull request, comment:
  • atlantis apply

As I disabled the 'apply' command I assumed it would hide the "To apply this plan, comment:" and the "To apply all unapplied plans from this pull request, comment:" sections. Is my assumption correct, should it do that or am I doing something wrong?

Many thanks,

Lee

[nitrocode]

Oh perhaps that is a bug?

@krrrr38 depending on the allow-command flag, do we want to change the comment to remove plan/apply from it?

[leewilmott]

Thank you for your reply @nitrocode.

I did consider that it could be a bug.

I just want to pick up on something you said. You asked @krrrr38, "do we want to change the comment to remove plan/apply from it?". Just to be clear; because I have "version,plan" in the ATLANTIS_ALLOW_COMMANDS variable then I would like the 'plan' instructions to remain and the 'apply' instructions to be removed from the comment.

I hope that makes sense.

Thank you!

[leewilmott]

That is great...thank you for such a quick response and action.

[nitrocode]

Thanks Ken for the quick response! It does seems like a minor issue for now so please don't burn the midnight oil on it.

For now @leewilmott , please ignore it. We usually release every 4 to 6 weeks so a fix in a stable release may not make it until then. Once Ken fixes it, then you'd have to test off the dev tag image instead of the v0.22.3 image until the next stable release.

Thanks again for raising this issue.

[leewilmott]

@nitrocode, I understand. I'm perfectly happy with that. Thank you once again.

[krrrr38]

Sorry it's bug and fix it #3016.

[leewilmott]

Thank you both so much for addressing this so quickly.