Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Have some special case pages for problematic moves such as shines and magnets #45

Open
tupfold opened this issue Jul 1, 2024 · 0 comments

Comments

@tupfold
Copy link
Contributor

tupfold commented Jul 1, 2024

I've seen the rukaidata bot struggle a few times with requests for shines and magnet moves, which I assume is due to the special nature of the move animations (initial + hold + hit + end). I think it's a broad enough category that some special case handling for these moves is maybe ok.

I was thinking something like the following:

  • Keep existing gif generated for each part of the move
  • Have a special case webpage generated for problematic moves which bundles all the animations together in three sections. This basically be the existing pages for each of the move sections stuck together (e.g. section for initial showing gif + table+ scripts, then section for hold with similar, etc.)
  • Special cases hard coded as a list of (character, move, most useful animation segment) pairs and checked when generated pages
  • Combined special cases appear under SpecialLw so that bot lookups are nicer
  • Discord preview shows gif for most useful animation segment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant