Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new Loader().contentLoaderInfo.loaderURL returns file:// instead of whole path #14217

Open
evilpie opened this issue Nov 28, 2023 · 4 comments · May be fixed by #17717
Open

new Loader().contentLoaderInfo.loaderURL returns file:// instead of whole path #14217

evilpie opened this issue Nov 28, 2023 · 4 comments · May be fixed by #17717
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working

Comments

@evilpie
Copy link
Collaborator

evilpie commented Nov 28, 2023

In Flash new Loader().contentLoaderInfo.loaderURL returns the whole path of the SWF, in Ruffle it's just file:///.

The value probably comes from either SwfMovie::empty or SwfMovie::empty_fake_compressed_len.
@danielhjacobs
Copy link
Contributor

https://github.com/ruffle-rs/ruffle/blob/master/core/src/avm2/globals/flash/display/loader.rs#L41: Seems the comment here was not a good idea: "Some LoaderInfo properties (such as 'bytesLoaded' and 'bytesTotal') are always accessible, even before the 'init' event has fired. Using an empty movie gives us the correct value (0) for them."

@evilpie
Copy link
Collaborator Author

evilpie commented Nov 28, 2023

This happens for http://www.freeaddictinggames.com/loader/ima-vast-preroll.swf?v=2 from #8619 (comment).

@danielhjacobs
Copy link
Contributor

https://github.com/ruffle-rs/ruffle/blob/master/core/src/avm2/globals/flash/display/loader.rs#L41

This was added by @Aaron1011 in #7636.

@evilpie
Copy link
Collaborator Author

evilpie commented Nov 28, 2023

See also #13965, because even with the fixed URL the RegExp still fails anyway.

@Lord-McSweeney Lord-McSweeney added bug Something isn't working A-avm2 Area: AVM2 (ActionScript 3) labels Nov 28, 2023
@evilpie evilpie mentioned this issue Nov 30, 2023
Merged
@evilpie evilpie mentioned this issue Jan 21, 2024
Open
evilpie added a commit to evilpie/ruffle that referenced this issue Aug 31, 2024
@evilpie
avm2: Initialize the loaderURL for empty movies
7e064bf 
Fixes ruffle-rs#14217
@evilpie evilpie linked a pull request Aug 31, 2024 that will close this issue
Draft
evilpie added a commit to evilpie/ruffle that referenced this issue Sep 5, 2024
@evilpie
avm2: Initialize the loaderURL for empty movies
51b9181 
Fixes ruffle-rs#14217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avm2: Initialize the loaderURL for empty movies evilpie/ruffle
3 participants
@evilpie @danielhjacobs @Lord-McSweeney