Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias names are too permissive in SnakeYAML-Engine #689

Open
headius opened this issue Oct 6, 2024 · 11 comments
Open

Alias names are too permissive in SnakeYAML-Engine #689

headius opened this issue Oct 6, 2024 · 11 comments

Comments

@headius
Copy link
Contributor

headius commented Oct 6, 2024

See original issue at jruby/jruby#8352.

The following YAML fails to parse in SnakeYAML-Engine, used by the JRuby Psych extension:

--- &1 !ruby/object:Set
hash:
  :one: true
  :two: true
  *1: true

This is due to a bug in SnakeYAML-Engine reported here: https://bitbucket.org/snakeyaml/snakeyaml-engine/issues/54/do-not-allow-colon-to-be-a-part-of-an

This will be fixed shortly in an upcoming release of SnakeYAML-Engine. Psych will need to be updated to the new version and released.

@perlpunk
Copy link

perlpunk commented Oct 6, 2024

The proper fix is to add a space after the alias:

  *1 : true

It's valid to have a colon in anchor names (and yes, I agree that it should have been forbidden, but it isn't).

@headius
Copy link
Contributor Author

headius commented Oct 30, 2024

@asomov This is the Psych bug for the recent alias issue in SnakeYAML. Let us know if that fix is coming soon. Thank you!

@headius
Copy link
Contributor Author

headius commented Oct 30, 2024

@asomov Is that ready for testing on my end?

@asomov
Copy link

asomov commented Oct 30, 2024

@headius
Copy link
Contributor Author

headius commented Oct 30, 2024

@asomov Success! Combining your snapshot jar with my other fix jruby/jruby#8394, I can run the example from jruby/jruby#8352.

@asomov
Copy link

asomov commented Oct 31, 2024

@headius Great! Do you need an urgent release?

@headius
Copy link
Contributor Author

headius commented Oct 31, 2024

@asomov I don't know how much of an issue this is for @mcorino.

Releasing for us would be the psych gem first and then adding that to the JRuby release, but with our next JRuby release a week away it's too close. So whenever you can release is fine for us, and I can update the gem the same day.

@mcorino
Copy link

mcorino commented Oct 31, 2024

@headius @asomov Fine by me.

@asomov
Copy link

asomov commented Oct 31, 2024

@headius @mcorino please ping me in advance (a week) to release when you need it (I will wait for other possible changes)

@mcorino
Copy link

mcorino commented Oct 31, 2024

@asomov @headius The issue is currently not blocking for me (I would like it fixed) so any time you get to it is fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants