You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Agreed, ErrorHighlight is an internal gem, it should not expose any public method.
Let's design this kind of things properly and not make them ErrorHighlight-specific.
searls
added a commit
to testdouble/mocktail
that referenced
this issue
Jan 27, 2022
error_highlight/lib/error_highlight/formatter.rb
Line 16 in 9fbaa8a
I believe it would be prudent at least for the first stable release of this gem, to remove the
ErrorHighlight#formatter
override.I believe it will be very hard to use in practice and adds unnecessary public interface and complexity.
The text was updated successfully, but these errors were encountered: