Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom formatter #15

Open
ioquatix opened this issue Nov 10, 2021 · 1 comment
Open

Remove custom formatter #15

ioquatix opened this issue Nov 10, 2021 · 1 comment

Comments

@ioquatix
Copy link
Member

I believe it would be prudent at least for the first stable release of this gem, to remove the ErrorHighlight#formatter override.

I believe it will be very hard to use in practice and adds unnecessary public interface and complexity.

@eregon
Copy link
Member

eregon commented Nov 10, 2021

Agreed, ErrorHighlight is an internal gem, it should not expose any public method.
Let's design this kind of things properly and not make them ErrorHighlight-specific.

searls added a commit to testdouble/mocktail that referenced this issue Jan 27, 2022
I don't like the changes to the output under ruby 3.1 but will wait to dig in further until I hear back with respect to:

ruby/error_highlight#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants