Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider folding Bunny::Transport into Bunny::Session #703

Open
michaelklishin opened this issue Feb 21, 2025 · 0 comments
Open

Consider folding Bunny::Transport into Bunny::Session #703

michaelklishin opened this issue Feb 21, 2025 · 0 comments
Milestone

Comments

@michaelklishin
Copy link
Member

Bunny::Transport was originally introduced to separate Bunny::Session, a part of the original 2009 design, from the 2 socket implementations (MRI, JRuby) x two socket types ("plain" TCP, TLS).

As of #701 #702, this layer layer is likely unnecessary and Bunny::Transport can be merged with Bunny::Session.

Backwards Compatibility Considerations

c = Bunny.new
c.transport.configure_socket |socket|
end

can be reimplemented by making Bunny::Session#transport return self.

@michaelklishin michaelklishin added this to the 3.0.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant