Improve test coverage #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
commented
Feb 12, 2025
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| SimpleCov.start do | |||
| enable_coverage :branch | |||
| minimum_coverage line: 95.17, branch: 85.13 | |||
| minimum_coverage line: 100, branch: 100 | |||
bquorning
force-pushed
the
improve-test-coverage
branch
from
362c6a9 to
7ae719f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we do two things:
caseorifexhausts all branches, but the lastwhen/elsifdocuments behavior we don't want to just change it to a fallbackelse. In that case we add a:nooporraise ArgumentErrorand use:nocov:to tell SimpleCov to ignore it.Those two commits bring line and branch coverage to 100% ✨
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).