Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is unclear why RSpec/Rails/HaveHttpStatus is SafeAutoCorrect: false in document #5

Open
ydah opened this issue Mar 26, 2024 · 3 comments · May be fixed by #60
Open

It is unclear why RSpec/Rails/HaveHttpStatus is SafeAutoCorrect: false in document #5

ydah opened this issue Mar 26, 2024 · 3 comments · May be fixed by #60
Labels
documentation Improvements or additions to documentation

Comments

@ydah
Copy link
Member

ydah commented Mar 26, 2024

In the case of SafeAutoCorrect: false, the reason is generally written in the Safety block, so I think it should also be written in RSpec/Rails/HaveHttpStatus.
@ydah
Copy link
Member Author

ydah commented Mar 26, 2024

Resolve after migration to rubocop-rspec_rails

@ydah
Copy link
Member Author

ydah commented Mar 26, 2024

memo) reason: rubocop/rubocop-rspec#1307 (comment)

@ydah
Copy link
Member Author

ydah commented Mar 26, 2024

But in this case, it looks like Safe is false, not SafeAutocorrect is false.

@ydah ydah transferred this issue from rubocop/rubocop-rspec Mar 29, 2024
@ydah ydah added the documentation Improvements or additions to documentation label Mar 31, 2024
ydah added a commit that referenced this issue Feb 13, 2025
@ydah
Change RSpecRails/HaveHttpStatus from Autocorrect: false to `Safe…
5547ab7 
…: false`

Fixes: #5

This is because `response.status` is not always the HTTP response as commented below. I don't think this is an autocorrect is not safe. What do you think?
rubocop/rubocop-rspec#1307 (comment)
@ydah ydah linked a pull request Feb 13, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add safety note for autocorrection in have_http_status cop rubocop/rubocop-rspec_rails
1 participant
@ydah