Change RSpecRails/HaveHttpStatus from Autocorrect: false to `Safe…

…: false`

Fixes: #5

This is because `response.status` is not always the HTTP response as commented below. I don't think this is an autocorrect is not safe. What do you think?
rubocop/rubocop-rspec#1307 (comment)

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 - Handle unknown HTTP status codes for `RSpecRails/HttpStatus` cop. ([@viralpraxis])
+- Change `RSpecRails/HaveHttpStatus` from `Autocorrect: false` to `Safe: false`. ([@ydah])
 
 ## 2.30.0 (2024-06-12)
 

config/default.yml

@@ -18,9 +18,9 @@ RSpecRails/HaveHttpStatus:
   ResponseMethods:
     - response
     - last_response
-  SafeAutoCorrect: false
+  Safe: false
   VersionAdded: '2.12'
-  VersionChanged: '2.27'
+  VersionChanged: "<<next>>"
   Reference: https://www.rubydoc.info/gems/rubocop-rspec_rails/RuboCop/Cop/RSpecRails/HaveHttpStatus
 
 RSpecRails/HttpStatus:

docs/modules/ROOT/pages/cops_rspecrails.adoc

@@ -49,14 +49,20 @@ end
 | Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
 
 | Pending
-| Yes
+| No
 | Always (Unsafe)
 | 2.12
-| 2.27
+| <<next>>
 |===
 
 Checks that tests use `have_http_status` instead of equality matchers.
 
+[#safety-rspecrailshavehttpstatus]
+=== Safety
+
+This cop is marked as unsafe because
+`response.status` response is not always an HTTP response.
+
 [#examples-rspecrailshavehttpstatus]
 === Examples
 

lib/rubocop/cop/rspec_rails/have_http_status.rb

@@ -5,6 +5,10 @@ module Cop
     module RSpecRails
       # Checks that tests use `have_http_status` instead of equality matchers.
       #
+      # @safety
+      #   This cop is marked as unsafe because
+      #   `response.status` response is not always an HTTP response.
+      #
       # @example ResponseMethods: ['response', 'last_response'] (default)
       #   # bad
       #   expect(response.status).to be(200)