Config formatter coverage #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I was about to raise an issue on this because of the String/Array mismatch. Glad you knew how to fix it! |
corsonknowles
approved these changes
Feb 9, 2025
| @@ -8,6 +8,12 @@ | |||
| 'AllCops' => { | |||
| 'Setting' => 'forty two' | |||
| }, | |||
| 'Metrics/BlockLength' => { | |||
There was a problem hiding this comment.
Nice the spec explains the behavior now!
bquorning
force-pushed
the
config-formatter-coverage
branch
from
6764c53 to
73bc726
Compare
Its last use was before v3.0.0, before `RSpec/Capybara` was extracted.
AMENDMENTS was defined as a String, not an Array. And splatting the array into `#gsub` doesn't work if there is more than one element - we would need to use `Regexp.union` instead... but actually I ended up removing AMENDMENTS altogether. All we want to do is to add an extra newline before each cop entry. Only new cop entries starts at the beginning of line, and contains a slash character after the first word. This means we don't need AMENDMENTS at all, and we no longer need the capture in EXTENSION_ROOT_DEPARTMENT.
bquorning
force-pushed
the
config-formatter-coverage
branch
from
79a329f to
e79ec49
Compare
pirj
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUBDEPARTMENTSwas last used in ConfigFormatter before we released v3.0.0, beforeRSpec/Capybarawas extracted. It’s being removed in this PR.Also, initially wanting to improve spec branch coverage for ConfigFormatter,
I found thatActually I ended up removingAMENDMENTSwas defined as a String, not an Array. And splatting the array into#gsubdoesn't work if there is more than one element - we need to useRegexp.unioninstead.AMENDMENDSaltogether.To avoid conflicts with other PRs improving code coverage, the .simplecov file is not updated here.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).Added an entry to theCHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).