Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add ZStandard Codec Support #35

Closed
kcgen opened this issue Oct 23, 2020 · 10 comments
Closed

Suggestion: Add ZStandard Codec Support #35

kcgen opened this issue Oct 23, 2020 · 10 comments

Comments

@kcgen
Copy link

kcgen commented Oct 23, 2020

ZStandard Codec Support

  • Likely supported via LibZStandard
  • Pass-through of API settings for common ZStandard features such as: number of cores, block sizes, compression settings, and so on.
  • The API will allow emulator-specific and platform-specific settings to optimize the performance of of the library.
@Sanaki
Copy link
Contributor

Sanaki commented Oct 24, 2020

This repo is a library for reading MAME's chd format. It doesn't have any influence over the chd format itself. For that, you'll need to open issues on https://github.com/mamedev/mame/.

@kcgen
Copy link
Author

kcgen commented Oct 24, 2020

Thanks @Sanaki! (Closing)

@kcgen kcgen closed this as completed Oct 24, 2020
@Sanaki
Copy link
Contributor

Sanaki commented Oct 24, 2020

I'd imagine this applies to #34 and #36 as well. Feel free to correct me if I'm wrong though.
EDIT: I read over them again, not actually sure it does.

@kcgen kcgen changed the title Suggestions for v6 - ZStandard Codec Support Suggestion: Add ZStandard Codec Support Oct 24, 2020
@kcgen
Copy link
Author

kcgen commented Oct 24, 2020

(Ref: mamedev/mame#7386)

@InquisitiveCoder
Copy link

Can this be revisited? MAME just added zstd support to chdman in this PR: mamedev/mame#11827

@rtissera
Copy link
Owner

rtissera commented Dec 11, 2023 via email

@malvarenga123
Copy link

Should this issue be reopened until it's implemented?

@rtissera
Copy link
Owner

rtissera commented Jan 9, 2024

Yes since MAME chaman now does it.

@rtissera rtissera reopened this Jan 9, 2024
@Sanaki
Copy link
Contributor

Sanaki commented Feb 2, 2024

I believe this was resolved in #106 and can be closed again.

@rtissera
Copy link
Owner

rtissera commented Feb 3, 2024

Yes, indeed, MAME team bit the bullet and implemented in chdman 0.262
It needs to be manually specified at compression time.
Closing.

@rtissera rtissera closed this as completed Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants