Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting the ensure new bundles include expected_result.txt and manifest.json #6

Open
cgraham-rs opened this issue Jul 31, 2024 · 0 comments · May be fixed by #8
Open

Add linting the ensure new bundles include expected_result.txt and manifest.json #6

cgraham-rs opened this issue Jul 31, 2024 · 0 comments · May be fixed by #8
Labels
enhancement New feature or request

Comments

@cgraham-rs
Copy link
Collaborator

cgraham-rs commented Jul 31, 2024

We need automated linting to protect from merges that include bundles that are missing required files to support Marketplace automation.

Otherwise when executing Connect Marketplace automation this can happen.

❯ pytest platform_integration_tests/tests/connect --tracing retain-on-failure --output test-results
========================================================================================= test session starts ==========================================================================================
platform darwin -- Python 3.11.7, pytest-8.2.2, pluggy-1.5.0
rootdir: /Users/christophergraham/dev/platform-integration-tests
configfile: pyproject.toml
plugins: playwright-0.5.0, dependency-0.6.0, base-url-2.1.0, retry-1.6.3, xdist-3.6.1
collected 0 items / 1 error                                                                                                                                                                            

================================================================================================ ERRORS ================================================================================================
______________________________________________________________ ERROR collecting platform_integration_tests/tests/connect/test_connect.py _______________________________________________________________
platform_integration_tests/tests/connect/content.py:68: in jump_start_bundles
    resp.raise_for_status()
.venv/lib/python3.11/site-packages/requests/models.py:1024: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
E   requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://api.github.com/repos/rstudio/jumpstart_examples/contents/bundles/square-plot/expected_result.txt

During handling of the above exception, another exception occurred:
platform_integration_tests/tests/connect/test_connect.py:44: in <module>
    @pytest.mark.parametrize("bundle_name, expected_result", jump_start_bundles())
platform_integration_tests/tests/connect/content.py:70: in jump_start_bundles
    raise Exception(e)
E   Exception: 404 Client Error: Not Found for url: https://api.github.com/repos/rstudio/jumpstart_examples/contents/bundles/square-plot/expected_result.txt
======================================================================================= short test summary info ========================================================================================
ERROR platform_integration_tests/tests/connect/test_connect.py - Exception: 404 Client Error: Not Found for url: https://api.github.com/repos/rstudio/jumpstart_examples/contents/bundles/square-plot/expected_result.txt
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
=========================================================================================== 1 error in 3.17s ===========================================================================================
@cgraham-rs cgraham-rs changed the title Add protection against pushes that include a new bundle, but is missing expected_result.txt or manifest.json Add linting the ensure new bundles include expected_result.txt and manifest.json Aug 1, 2024
@cgraham-rs cgraham-rs added the enhancement New feature or request label Aug 1, 2024
@cgraham-rs cgraham-rs linked a pull request Aug 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant