Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --color flag and respect color option #839

Closed
evan-goode opened this issue Aug 25, 2023 · 1 comment · Fixed by #1750
Closed

Implement --color flag and respect color option #839

evan-goode opened this issue Aug 25, 2023 · 1 comment · Fixed by #1750
Labels
Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@evan-goode
Copy link
Member

Noticed by a participant in the 2023-08-11 test week: https://fedoraproject.org/wiki/Test_Day:2023-08-11_Fedora_39_DNF_5#cite_note-74.

  1. For commands that produce colorful output, such as info, search, and list, colors are currently shown iff stdout is a terminal, which is the behavior of --setopt=color=auto. color=always and color=never are not respected.
  2. The --color=auto|never|always argument to set the color configuration option is missing.

These items are probably low priority; color=auto is desired in the vast majority of cases. But some scripts may invoke dnf --color=never ... and it would be nice to not break them.
@github-project-automation github-project-automation bot moved this to Backlog in DNF team Aug 25, 2023
@kontura kontura added Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take labels Sep 18, 2023
@alimirjamali alimirjamali mentioned this issue Oct 1, 2024
Open
alimirjamali added a commit to alimirjamali/dnf5 that referenced this issue Oct 2, 2024
@alimirjamali
Reimplement --color flag
3d2895d 
resolves: rpm-software-management#839
related: QubesOS/qubes-issues#9482
@alimirjamali alimirjamali mentioned this issue Oct 2, 2024
Merged
@alimirjamali
Copy link
Contributor

PR Submitted.
We specifically require this option for QubesOS

review priority: low

alimirjamali added a commit to alimirjamali/dnf5 that referenced this issue Feb 8, 2025
@alimirjamali
Reimplement --color flag
d57f88c 
resolves: rpm-software-management#839
related: QubesOS/qubes-issues#9482
alimirjamali added a commit to alimirjamali/dnf5 that referenced this issue Mar 19, 2025
@alimirjamali
Reimplement --color flag
8def3ba 
resolves: rpm-software-management#839
related: QubesOS/qubes-issues#9482
alimirjamali added a commit to alimirjamali/dnf5 that referenced this issue Mar 19, 2025
@alimirjamali
Reimplement --color flag
2366e02 
resolves: rpm-software-management#839
related: QubesOS/qubes-issues#9482
alimirjamali added a commit to alimirjamali/dnf5 that referenced this issue Mar 20, 2025
@alimirjamali
Reimplement --color flag
0a38608 
resolves: rpm-software-management#839
related: QubesOS/qubes-issues#9482
github-merge-queue bot pushed a commit that referenced this issue Mar 20, 2025
@alimirjamali @jrohel
Reimplement --color flag
6b361a6 
resolves: #839
related: QubesOS/qubes-issues#9482
@github-project-automation github-project-automation bot moved this from Backlog to Done in DNF team Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: LOW Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
DNF team
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reimplement --color flag alimirjamali/dnf5
3 participants
@alimirjamali @evan-goode @kontura