Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluginlib ament index resource types should use periods as a separator #237

Open
sloretz opened this issue Jul 14, 2022 · 0 comments
Open

Comments

@sloretz
Copy link
Contributor

sloretz commented Jul 14, 2022

Currently pluginlib_export_plugin_description_file() creates a resource type in the ament index called {plugin category}__pluginlib__plugin. However, This seems like "nesting resource types" to me. The ament resource index documentation says for nested resource types "[...] the convention of using prefixes and suffixes separated by periods should be used.".

For example, RViz plugins are listed as the resource type rviz_common__pluginlib__plugin, but I think resource types like pluginlib.rviz_common or pluginlib.plugin.rviz_common or plugin.rviz_common would be closer to the ament_index documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant