-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rosdistro entries source/docs for released distributions from 'ros2' for rolling #458
Comments
That's just the doc link. But, yeah, that's one of the downsides of rolling's auto-release into new distributions, it just fills in the rolling branch's fields that might not be appropriate and are easy to not catch when running releases since its non-software. When I run releases, its on the proper distribution branch, not I don't think for a package like this any ABI breaking change is acceptable for anything as critical as message filters, that should be only done for Jazzy and newer. I hope you're not saying that |
New changes are only for |
Oh yeah, then I think we're on board! Is the confusion just that the docs portion says |
I can see in rosdistro that |
Check out the actual releases https://github.com/ros-perception/perception_pcl/releases, the software targets its branches. Keep in mind that when rolling forks into a new distribution, it populates the rolling fields. It looks like I / we didn't I'll rename the ticket for making that update since I think that's the real bug that you're reporting? |
We are planning to break ABI on message_filter I created this PR #457 to fix the build job but I can see an issue in rosdistro.
There are branches for
humble
,iron
androlling (ros2 branch)
but all rosdistro distributions are pointing to theros2
branchBut I also check that there are some activity at least on the
humble
branch.I would love to hear from the maintainers what to do here.
humble
,iron
andjazzy
with the actualros2
branch? and update rosdistro ? but this might destroy some work done for these old distrosros2
and then continue working on ros2The text was updated successfully, but these errors were encountered: