New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge ExtractImagesNode into ImageSaver #935

Open

3 tasks

mikeferguson opened this issue Feb 8, 2024 · 0 comments

Labels

enhancement good first issue in progress ros2

Member

mikeferguson commented Feb 8, 2024 •

edited

Loading

Functionality is largely the same, we should:

Replace "secs_per_frame" by adding new "fps" parameter to ImageSaver - when the parameter is set, we should setup a timer to fire and save images. (see also sec_per_frame_ is unintuitive #274)
Update file format to be "frameX" rather than "leftX"
Use the encoding of the image message, falling back to the "encoding" parameter only when empty.

mikeferguson added enhancement ros2 good first issue labels

mikeferguson mentioned this issue

migrate image_view docs #934

Merged

CursedRock17 mentioned this issue

Initial Merging: Setting up ImageSaverNode #944

Open

mikeferguson added the in progress label

mikeferguson mentioned this issue

sec_per_frame_ is unintuitive #274

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment