Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Commit 9591f8a

Browse files
akornichakornich
authored
Merge pull request #268 from WideSpectrumComputing/master
release candidate: v1.12.3
2 parents 0448915 + 767c2e8 commit 9591f8a

File tree

8 files changed

+192
-19
lines changed

8 files changed

+192
-19
lines changed

‎CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ The change log has moved to this repo's [GitHub Releases Page](https://github.co
2525

2626
## Release Notes
2727

28+
**1.12.3**
29+
- fix: resolve #154: Reporting to multiple projects
30+
2831
**1.12.2**
2932
- fix: resolve #266: Telemetry events timestamp is rendered as a string instead of expected "as a number"
3033

‎Rollbar.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22

3-
s.version = "1.12.2"
3+
s.version = "1.12.3"
44
s.name = "Rollbar"
55
s.summary = "Objective-C library for crash reporting and logging with Rollbar. It works on iOS and macOS."
66
s.description = <<-DESC

‎Rollbar.xcodeproj/project.pbxproj

+10-10
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,6 @@
411411
55454B3F22C69DDD00D4A414 /* KSCrashReportFixer.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DC1FDA6CA600A6AB0C /* KSCrashReportFixer.h */; };
412412
55454B4022C69DDD00D4A414 /* KSCrashDoctor.m in Sources */ = {isa = PBXBuildFile; fileRef = B54F19DD1FDA6CA600A6AB0C /* KSCrashDoctor.m */; };
413413
55454B4122C69DDD00D4A414 /* KSCrashReport.c in Sources */ = {isa = PBXBuildFile; fileRef = B54F19DE1FDA6CA600A6AB0C /* KSCrashReport.c */; };
414-
55454B4222C69DDD00D4A414 /* KSCrash.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DF1FDA6CA600A6AB0C /* KSCrash.h */; settings = {ATTRIBUTES = (Public, ); }; };
415414
55454B4322C69DDD00D4A414 /* KSCrashReportStore.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19E01FDA6CA600A6AB0C /* KSCrashReportStore.h */; };
416415
55454B4422C69DDD00D4A414 /* KSCrashCachedData.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19E11FDA6CA600A6AB0C /* KSCrashCachedData.h */; };
417416
55454B4522C69DDD00D4A414 /* KSCrashC.c in Sources */ = {isa = PBXBuildFile; fileRef = B54F19E21FDA6CA600A6AB0C /* KSCrashC.c */; };
@@ -425,7 +424,6 @@
425424
55454B4D22C69DDE00D4A414 /* KSCrashReportFixer.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DC1FDA6CA600A6AB0C /* KSCrashReportFixer.h */; };
426425
55454B4E22C69DDE00D4A414 /* KSCrashDoctor.m in Sources */ = {isa = PBXBuildFile; fileRef = B54F19DD1FDA6CA600A6AB0C /* KSCrashDoctor.m */; };
427426
55454B4F22C69DDE00D4A414 /* KSCrashReport.c in Sources */ = {isa = PBXBuildFile; fileRef = B54F19DE1FDA6CA600A6AB0C /* KSCrashReport.c */; };
428-
55454B5022C69DDE00D4A414 /* KSCrash.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DF1FDA6CA600A6AB0C /* KSCrash.h */; settings = {ATTRIBUTES = (Public, ); }; };
429427
55454B5122C69DDE00D4A414 /* KSCrashReportStore.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19E01FDA6CA600A6AB0C /* KSCrashReportStore.h */; };
430428
55454B5222C69DDE00D4A414 /* KSCrashCachedData.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19E11FDA6CA600A6AB0C /* KSCrashCachedData.h */; };
431429
55454B5322C69DDE00D4A414 /* KSCrashC.c in Sources */ = {isa = PBXBuildFile; fileRef = B54F19E21FDA6CA600A6AB0C /* KSCrashC.c */; };
@@ -676,7 +674,6 @@
676674
55454C8822C6AE7400D4A414 /* KSCrashReportFixer.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DC1FDA6CA600A6AB0C /* KSCrashReportFixer.h */; };
677675
55454C8922C6AE7400D4A414 /* KSCrashDoctor.m in Sources */ = {isa = PBXBuildFile; fileRef = B54F19DD1FDA6CA600A6AB0C /* KSCrashDoctor.m */; };
678676
55454C8A22C6AE7400D4A414 /* KSCrashReport.c in Sources */ = {isa = PBXBuildFile; fileRef = B54F19DE1FDA6CA600A6AB0C /* KSCrashReport.c */; };
679-
55454C8B22C6AE7400D4A414 /* KSCrash.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DF1FDA6CA600A6AB0C /* KSCrash.h */; settings = {ATTRIBUTES = (Public, ); }; };
680677
55454C8C22C6AE7400D4A414 /* KSCrashReportStore.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19E01FDA6CA600A6AB0C /* KSCrashReportStore.h */; };
681678
55454C8D22C6AE7400D4A414 /* KSCrashCachedData.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19E11FDA6CA600A6AB0C /* KSCrashCachedData.h */; };
682679
55454C8E22C6AE7400D4A414 /* KSCrashC.c in Sources */ = {isa = PBXBuildFile; fileRef = B54F19E21FDA6CA600A6AB0C /* KSCrashC.c */; };
@@ -690,7 +687,6 @@
690687
55454C9622C6AE7500D4A414 /* KSCrashReportFixer.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DC1FDA6CA600A6AB0C /* KSCrashReportFixer.h */; };
691688
55454C9722C6AE7500D4A414 /* KSCrashDoctor.m in Sources */ = {isa = PBXBuildFile; fileRef = B54F19DD1FDA6CA600A6AB0C /* KSCrashDoctor.m */; };
692689
55454C9822C6AE7500D4A414 /* KSCrashReport.c in Sources */ = {isa = PBXBuildFile; fileRef = B54F19DE1FDA6CA600A6AB0C /* KSCrashReport.c */; };
693-
55454C9922C6AE7500D4A414 /* KSCrash.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DF1FDA6CA600A6AB0C /* KSCrash.h */; settings = {ATTRIBUTES = (Public, ); }; };
694690
55454C9A22C6AE7500D4A414 /* KSCrashReportStore.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19E01FDA6CA600A6AB0C /* KSCrashReportStore.h */; };
695691
55454C9B22C6AE7500D4A414 /* KSCrashCachedData.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19E11FDA6CA600A6AB0C /* KSCrashCachedData.h */; };
696692
55454C9C22C6AE7500D4A414 /* KSCrashC.c in Sources */ = {isa = PBXBuildFile; fileRef = B54F19E21FDA6CA600A6AB0C /* KSCrashC.c */; };
@@ -986,6 +982,10 @@
986982
554B97CD238FA0C1003DC4ED /* RollbarCallStackFrame.m in Sources */ = {isa = PBXBuildFile; fileRef = 554B97C7238FA0C1003DC4ED /* RollbarCallStackFrame.m */; };
987983
554B97CE238FA0C1003DC4ED /* RollbarCallStackFrame.m in Sources */ = {isa = PBXBuildFile; fileRef = 554B97C7238FA0C1003DC4ED /* RollbarCallStackFrame.m */; };
988984
554B97CF238FA0C1003DC4ED /* RollbarCallStackFrame.m in Sources */ = {isa = PBXBuildFile; fileRef = 554B97C7238FA0C1003DC4ED /* RollbarCallStackFrame.m */; };
985+
556FF135242D6BFF00925DD1 /* KSCrash.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DF1FDA6CA600A6AB0C /* KSCrash.h */; settings = {ATTRIBUTES = (Public, ); }; };
986+
556FF136242D6C0000925DD1 /* KSCrash.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DF1FDA6CA600A6AB0C /* KSCrash.h */; settings = {ATTRIBUTES = (Public, ); }; };
987+
556FF137242D6C0400925DD1 /* KSCrash.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DF1FDA6CA600A6AB0C /* KSCrash.h */; settings = {ATTRIBUTES = (Public, ); }; };
988+
556FF138242D6C0600925DD1 /* KSCrash.h in Headers */ = {isa = PBXBuildFile; fileRef = B54F19DF1FDA6CA600A6AB0C /* KSCrash.h */; settings = {ATTRIBUTES = (Public, ); }; };
989989
557A4E19236262460034BB55 /* RollbarScrubbingOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 557A4E17236262460034BB55 /* RollbarScrubbingOptions.h */; settings = {ATTRIBUTES = (Public, ); }; };
990990
557A4E1A236262460034BB55 /* RollbarScrubbingOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 557A4E17236262460034BB55 /* RollbarScrubbingOptions.h */; settings = {ATTRIBUTES = (Public, ); }; };
991991
557A4E1B236262460034BB55 /* RollbarScrubbingOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 557A4E17236262460034BB55 /* RollbarScrubbingOptions.h */; settings = {ATTRIBUTES = (Public, ); }; };
@@ -2451,6 +2451,7 @@
24512451
55454B2C22C69DD100D4A414 /* KSObjC.h in Headers */,
24522452
554549F822C69A2A00D4A414 /* Deployment.h in Headers */,
24532453
55F7D9512375E81300F9932D /* DeployApiCallOutcome.h in Headers */,
2454+
556FF136242D6C0000925DD1 /* KSCrash.h in Headers */,
24542455
55A5588E2356474F00D8898A /* CaptureIpType.h in Headers */,
24552456
55454ABF22C69DBC00D4A414 /* KSCrashMonitor_MachException.h in Headers */,
24562457
55454B3122C69DD100D4A414 /* KSStackCursor_MachineContext.h in Headers */,
@@ -2459,7 +2460,6 @@
24592460
5518C80D23F4E529005692D2 /* Rollbar.h in Headers */,
24602461
55454A3022C69C1000D4A414 /* RollbarTelemetry.h in Headers */,
24612462
55454A8B22C69DA300D4A414 /* KSCrashReportSinkEMail.h in Headers */,
2462-
55454B5022C69DDE00D4A414 /* KSCrash.h in Headers */,
24632463
558AFFED2409F87E0015E13E /* RollbarTelemetryBody.h in Headers */,
24642464
55454B9122C69E2B00D4A414 /* DemangleNodes.h in Headers */,
24652465
558A001F2409F9800015E13E /* RollbarTelemetryNetworkBody.h in Headers */,
@@ -2623,6 +2623,7 @@
26232623
55A5588D2356474F00D8898A /* CaptureIpType.h in Headers */,
26242624
55454A1F22C69B6800D4A414 /* RollbarLevel.h in Headers */,
26252625
557A4E19236262460034BB55 /* RollbarScrubbingOptions.h in Headers */,
2626+
556FF135242D6BFF00925DD1 /* KSCrash.h in Headers */,
26262627
55454A6A22C69D9700D4A414 /* NSString+URLEncode.h in Headers */,
26272628
55927085234EE7EA0087E01F /* JSONSupport.h in Headers */,
26282629
554549F522C69A1E00D4A414 /* RollbarDeploysProtocol.h in Headers */,
@@ -2663,7 +2664,6 @@
26632664
55454A2B22C69BFF00D4A414 /* RollbarReachability.h in Headers */,
26642665
554549FB22C69A3B00D4A414 /* DeploymentDetails.h in Headers */,
26652666
55454A8022C69DA300D4A414 /* KSCrashReportSinkStandard.h in Headers */,
2666-
55454B4222C69DDD00D4A414 /* KSCrash.h in Headers */,
26672667
55454B4422C69DDD00D4A414 /* KSCrashCachedData.h in Headers */,
26682668
55454A1322C69B1500D4A414 /* RollbarFileReader.h in Headers */,
26692669
5583C6D92396293D00C52617 /* TriStateFlag.h in Headers */,
@@ -2697,7 +2697,6 @@
26972697
55454CAB22C6AE7F00D4A414 /* KSCrashMonitor_User.h in Headers */,
26982698
5583C6B3239603A000C52617 /* HttpMethod.h in Headers */,
26992699
55454D4822C6AEAD00D4A414 /* Casting.h in Headers */,
2700-
55454C8B22C6AE7400D4A414 /* KSCrash.h in Headers */,
27012700
55454D5A22C6AED300D4A414 /* KSCrashInstallationConsole.h in Headers */,
27022701
55454CD222C6AE8C00D4A414 /* KSDebug.h in Headers */,
27032702
55454D4022C6AE9D00D4A414 /* None.h in Headers */,
@@ -2796,6 +2795,7 @@
27962795
55454CAF22C6AE7F00D4A414 /* KSCrashMonitor_AppState.h in Headers */,
27972796
55454CB622C6AE7F00D4A414 /* KSCrashMonitor_Zombie.h in Headers */,
27982797
55454C8822C6AE7400D4A414 /* KSCrashReportFixer.h in Headers */,
2798+
556FF137242D6C0400925DD1 /* KSCrash.h in Headers */,
27992799
55454CA122C6AE7F00D4A414 /* KSCrashMonitorContext.h in Headers */,
28002800
55454CE822C6AE8C00D4A414 /* KSStackCursor_Backtrace.h in Headers */,
28012801
55454C0722C6ACAC00D4A414 /* RollbarLevel.h in Headers */,
@@ -2869,7 +2869,6 @@
28692869
55454CC222C6AE8000D4A414 /* KSCrashMonitor_User.h in Headers */,
28702870
5583C6B4239603A000C52617 /* HttpMethod.h in Headers */,
28712871
55454D4C22C6AEAE00D4A414 /* Casting.h in Headers */,
2872-
55454C9922C6AE7500D4A414 /* KSCrash.h in Headers */,
28732872
55454D6922C6AED400D4A414 /* KSCrashInstallationConsole.h in Headers */,
28742873
55454D0B22C6AE8D00D4A414 /* KSDebug.h in Headers */,
28752874
55454D4322C6AE9F00D4A414 /* None.h in Headers */,
@@ -2968,6 +2967,7 @@
29682967
55454CC622C6AE8000D4A414 /* KSCrashMonitor_AppState.h in Headers */,
29692968
55454CCD22C6AE8000D4A414 /* KSCrashMonitor_Zombie.h in Headers */,
29702969
55454C9622C6AE7500D4A414 /* KSCrashReportFixer.h in Headers */,
2970+
556FF138242D6C0600925DD1 /* KSCrash.h in Headers */,
29712971
55454CB822C6AE8000D4A414 /* KSCrashMonitorContext.h in Headers */,
29722972
55454D2122C6AE8D00D4A414 /* KSStackCursor_Backtrace.h in Headers */,
29732973
55454C0822C6ACAC00D4A414 /* RollbarLevel.h in Headers */,
@@ -4451,7 +4451,7 @@
44514451
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
44524452
CODE_SIGN_INJECT_BASE_ENTITLEMENTS = NO;
44534453
COPY_PHASE_STRIP = NO;
4454-
CURRENT_PROJECT_VERSION = 1.12.2;
4454+
CURRENT_PROJECT_VERSION = 1.12.3;
44554455
DEFINES_MODULE = YES;
44564456
DEVELOPMENT_TEAM = LDX6L68VZJ;
44574457
ENABLE_BITCODE = YES;
@@ -4516,7 +4516,7 @@
45164516
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
45174517
CODE_SIGN_INJECT_BASE_ENTITLEMENTS = NO;
45184518
COPY_PHASE_STRIP = YES;
4519-
CURRENT_PROJECT_VERSION = 1.12.2;
4519+
CURRENT_PROJECT_VERSION = 1.12.3;
45204520
DEFINES_MODULE = YES;
45214521
DEVELOPMENT_TEAM = LDX6L68VZJ;
45224522
ENABLE_BITCODE = YES;

‎Rollbar/Notifier/RollbarNotifier.m

+110-3
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ - (instancetype)initWithAccessToken:(NSString*)accessToken
6565
isRoot:isRoot];
6666

6767
if (isRoot) {
68+
69+
// make sure we have all the expected data directories/folder set:
70+
6871
NSString *cachesDirectory = [RollbarCachesDirectory directory];
6972
if (nil != self.configuration.logPayloadFile
7073
&& self.configuration.logPayloadFile.length > 0) {
@@ -77,6 +80,7 @@ - (instancetype)initWithAccessToken:(NSString*)accessToken
7780
payloadsFilePath =
7881
[cachesDirectory stringByAppendingPathComponent:PAYLOADS_FILE_NAME];
7982
}
83+
8084
// create working cache directory:
8185
if (![[NSFileManager defaultManager] fileExistsAtPath:cachesDirectory]) {
8286
NSError *error;
@@ -89,6 +93,8 @@ - (instancetype)initWithAccessToken:(NSString*)accessToken
8993
NSLog(@"result %@", result);
9094
}
9195

96+
// make sure we have all the data files set:
97+
9298
queuedItemsFilePath =
9399
[cachesDirectory stringByAppendingPathComponent:QUEUED_ITEMS_FILE_NAME];
94100
stateFilePath =
@@ -123,13 +129,16 @@ - (instancetype)initWithAccessToken:(NSString*)accessToken
123129
@"retry_count": [NSNumber numberWithUnsignedInt:0]} mutableCopy];
124130
}
125131

126-
// Deals with sending items that have been queued up
132+
// Setup the worker thread
133+
// that sends the items that have been queued up in the item file set above:
134+
127135
rollbarThread = [[RollbarThread alloc] initWithNotifier:self
128136
reportingRate:configuration.maximumReportsPerMinute];
129137
[rollbarThread start];
130138

131139
// Listen for reachability status
132-
// so that items are only sent when the internet is available
140+
// so that the items are only sent when the internet is available
141+
133142
reachability = [RollbarReachability reachabilityForInternetConnection];
134143

135144
isNetworkReachable = [reachability isReachable];
@@ -211,6 +220,7 @@ - (void)saveQueueState {
211220
}
212221

213222
- (void)processSavedItems {
223+
214224
if (!isNetworkReachable) {
215225
// Don't attempt sending if the network is known to be not reachable
216226
return;
@@ -647,6 +657,9 @@ - (void)queuePayload_OnlyCallOnThread:(NSDictionary *)payload {
647657
- (BOOL)sendItem:(NSDictionary*)payload
648658
nextOffset:(NSUInteger)nextOffset {
649659

660+
RollbarPayload *rollbarPayload =
661+
[[RollbarPayload alloc] initWithDictionary:[payload copy]];
662+
650663
NSMutableDictionary *newPayload =
651664
[NSMutableDictionary dictionaryWithDictionary:payload];
652665
[RollbarPayloadTruncator truncatePayload:newPayload];
@@ -677,7 +690,13 @@ - (BOOL)sendItem:(NSDictionary*)payload
677690
[fileHandle closeFile];
678691
}
679692

680-
BOOL success = [self sendPayload:jsonPayload];
693+
RollbarConfig *rollbarConfig =
694+
[[RollbarConfig alloc] initWithDictionary:rollbarPayload.data.notifier.jsonFriendlyData[@"configured_options"]];
695+
696+
BOOL success =
697+
rollbarConfig ? [self sendPayload:jsonPayload usingConfig:rollbarConfig]
698+
: [self sendPayload:jsonPayload]; // backward compatibility with just upgraded very old SDKs...
699+
681700
if (!success) {
682701
if (retryCount < MAX_RETRY_COUNT) {
683702
queueState[@"retry_count"] =
@@ -704,6 +723,94 @@ - (BOOL)sendItem:(NSDictionary*)payload
704723
return YES;
705724
}
706725

726+
- (BOOL)sendPayload:(nonnull NSData*)payload
727+
usingConfig:(nonnull RollbarConfig*)config {
728+
729+
NSURL *url = [NSURL URLWithString:config.destination.endpoint];
730+
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url];
731+
732+
[request setHTTPMethod:@"POST"];
733+
[request setValue:@"application/json" forHTTPHeaderField:@"Content-Type"];
734+
[request setValue:config.destination.accessToken forHTTPHeaderField:@"X-Rollbar-Access-Token"];
735+
[request setHTTPBody:payload];
736+
737+
if (YES == config.developerOptions.logPayload) {
738+
NSString *payloadString = [[NSString alloc]initWithData:payload
739+
encoding:NSUTF8StringEncoding
740+
];
741+
NSLog(@"%@", payloadString);
742+
//TODO: if config.developerOptions.logPayloadFile is defined, save the payload into the file...
743+
}
744+
745+
if (NO == config.developerOptions.transmit) {
746+
return YES; // we just successfully shortcircuit here...
747+
}
748+
749+
__block BOOL result = NO;
750+
#if TARGET_OS_IPHONE
751+
if (IS_IOS7_OR_HIGHER) {
752+
#else
753+
if (IS_MACOS10_10_OR_HIGHER) {
754+
#endif
755+
// This requires iOS 7.0+
756+
dispatch_semaphore_t sem = dispatch_semaphore_create(0);
757+
758+
NSURLSession *session = [NSURLSession sharedSession];
759+
760+
if (config.httpProxy.enabled
761+
|| config.httpsProxy.enabled) {
762+
763+
NSDictionary *connectionProxyDictionary =
764+
@{
765+
@"HTTPEnable" : [NSNumber numberWithBool:config.httpProxy.enabled],
766+
@"HTTPProxy" : config.httpProxy.proxyUrl,
767+
@"HTTPPort" : [NSNumber numberWithUnsignedInteger:config.httpProxy.proxyPort],
768+
@"HTTPSEnable" : [NSNumber numberWithBool:config.httpsProxy.enabled],
769+
@"HTTPSProxy" : config.httpsProxy.proxyUrl,
770+
@"HTTPSPort" : [NSNumber numberWithUnsignedInteger:config.httpsProxy.proxyPort]
771+
};
772+
773+
NSURLSessionConfiguration *sessionConfig =
774+
[NSURLSessionConfiguration ephemeralSessionConfiguration];
775+
sessionConfig.connectionProxyDictionary = connectionProxyDictionary;
776+
session = [NSURLSession sessionWithConfiguration:sessionConfig];
777+
}
778+
779+
NSURLSessionDataTask *dataTask =
780+
[session dataTaskWithRequest:request
781+
completionHandler:^(
782+
NSData * _Nullable data,
783+
NSURLResponse * _Nullable response,
784+
NSError * _Nullable error) {
785+
result = [self checkPayloadResponse:response
786+
error:error
787+
data:data];
788+
dispatch_semaphore_signal(sem);
789+
}];
790+
[dataTask resume];
791+
792+
dispatch_semaphore_wait(sem, DISPATCH_TIME_FOREVER);
793+
} else {
794+
// Using method sendSynchronousRequest, deprecated since iOS 9.0
795+
NSError *error;
796+
NSHTTPURLResponse *response;
797+
798+
#pragma clang diagnostic push
799+
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
800+
NSData *data = [NSURLConnection sendSynchronousRequest:request
801+
returningResponse:&response
802+
error:&error];
803+
#pragma clang diagnostic pop
804+
result = [self checkPayloadResponse:response
805+
error:error
806+
data:data];
807+
}
808+
809+
return result;
810+
}
811+
812+
/// This is a DEPRECATED method left for some backward compatibility for very old clients eventually moving to this more recent implementation.
813+
/// Use/maintain sendPayload:usingConfig: instead!
707814
- (BOOL)sendPayload:(NSData*)payload {
708815
NSURL *url = [NSURL URLWithString:self.configuration.endpoint];
709816
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url];

‎Rollbar/Notifier/RollbarThread.h

+7-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,13 @@
55

66
@interface RollbarThread : NSThread
77

8-
- (id)initWithNotifier:(RollbarNotifier*)notifier reportingRate:(NSUInteger)reportsPerMinute;
8+
/// Disallowed initializer
9+
- (instancetype)init
10+
NS_UNAVAILABLE;
11+
12+
- (instancetype)initWithNotifier:(RollbarNotifier*)notifier
13+
reportingRate:(NSUInteger)reportsPerMinute;
14+
//NS_DESIGNATED_INITIALIZER;
915

1016
@property(atomic) BOOL active;
1117

0 commit comments

Comments
 (0)