Skip to content

Commit 771f7ad

Browse files
authored
update ansible-galaxy resolvelib requirement to >= 0.5.3, < 2.0.0 (ansible#84218)
* Update resolvelib upperbound to 2.0.0 Minor SemVer releases should not contain breaking changes * Test the latest minor release and reduce number of resolvelib versions tested for efficiency
1 parent 68bfa37 commit 771f7ad

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
minor_changes:
2+
- ansible-galaxy - support ``resolvelib >= 0.5.3, < 2.0.0`` (https://github.com/ansible/ansible/issues/84217).

lib/ansible/galaxy/dependency_resolution/providers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class AbstractProvider: # type: ignore[no-redef]
3939

4040
# TODO: add python requirements to ansible-test's ansible-core distribution info and remove the hardcoded lowerbound/upperbound fallback
4141
RESOLVELIB_LOWERBOUND = SemanticVersion("0.5.3")
42-
RESOLVELIB_UPPERBOUND = SemanticVersion("1.1.0")
42+
RESOLVELIB_UPPERBOUND = SemanticVersion("2.0.0")
4343
RESOLVELIB_VERSION = SemanticVersion.from_loose_version(LooseVersion(resolvelib_version))
4444

4545

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ packaging
1212
# NOTE: Ref: https://github.com/sarugaku/resolvelib/issues/69
1313
# NOTE: When updating the upper bound, also update the latest version used
1414
# NOTE: in the ansible-galaxy-collection test suite.
15-
resolvelib >= 0.5.3, < 1.1.0 # dependency resolver used by ansible-galaxy
15+
resolvelib >= 0.5.3, < 2.0.0 # dependency resolver used by ansible-galaxy

test/integration/targets/ansible-galaxy-collection/vars/main.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@ gpg_homedir: "{{ galaxy_dir }}/gpg"
44

55
offline_server: https://test-hub.demolab.local/api/galaxy/content/api/
66

7+
# Test oldest and most recently supported, and versions with notable changes.
8+
# The last breaking change for a feature ansible-galaxy uses was in 0.8.0.
9+
# It would be redundant to test every minor version since 0.8.0, so we just test against the latest minor release.
10+
# NOTE: If ansible-galaxy incorporates new resolvelib features, this matrix should be updated to verify the features work on all supported versions.
711
supported_resolvelib_versions:
8-
- "0.5.3" # Oldest supported
9-
- "0.6.0"
10-
- "0.7.0"
11-
- "0.8.0"
12-
- "0.9.0"
13-
- "1.0.1"
12+
- "0.5.3" # test CollectionDependencyProvider050
13+
- "0.6.0" # test CollectionDependencyProvider060
14+
- "0.7.0" # test CollectionDependencyProvider070
15+
- "<2.0.0" # test CollectionDependencyProvider080
1416

1517
unsupported_resolvelib_versions:
1618
- "0.2.0" # Fails on import

test/lib/ansible_test/_data/requirements/ansible.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ packaging
1212
# NOTE: Ref: https://github.com/sarugaku/resolvelib/issues/69
1313
# NOTE: When updating the upper bound, also update the latest version used
1414
# NOTE: in the ansible-galaxy-collection test suite.
15-
resolvelib >= 0.5.3, < 1.1.0 # dependency resolver used by ansible-galaxy
15+
resolvelib >= 0.5.3, < 2.0.0 # dependency resolver used by ansible-galaxy

0 commit comments

Comments
 (0)