-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve setting woffMetaDataDescription #26
Comments
the ufoLib woffMetadataDescription validator requires both maybe the validator must be less strict on requiring the other woff info attributes dont require the Should I open an issue on fontTools.ufoLib? |
the patch could be: (replaces https://github.com/anthrotype/ufoLib/blob/master/Lib/ufoLib/validators.py#L374-L384 ) def fontInfoWOFFMetadataDescriptionValidator(value):
"""
Version 3+.
"""
dictPrototype = dict(url=(basestring, False), text=(list, False))
if not genericDictValidator(value, dictPrototype):
return False
if "text" in value:
for text in value["text"]:
if not fontInfoWOFFMetadataTextValue(text):
return False
return True I can make an fontTool PR if you like |
closing the issue here in as this has moved to fontTools ufoLib |
Reading the WOFF spec, the |
need to refactor the options are (the problem is you can not set multiple things at the same time, since that is galaxtically in space and time just not possible):
|
when setting the url field and no text is set it fails hard
see https://forum.robofont.com/topic/566/fontinfo-woff-description-url
The text was updated successfully, but these errors were encountered: