Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insert orphan glyph quicker by not copying #194

Open
typemytype opened this issue Jul 24, 2018 · 2 comments
Open

insert orphan glyph quicker by not copying #194

typemytype opened this issue Jul 24, 2018 · 2 comments

Comments

@typemytype
Copy link
Member

layer.insert() always copies the glyph, which is not always necessary

see https://github.com/typesupply/defcon/blob/master/Lib/defcon/objects/layer.py#L234-L235
if the glyph to insert has no layer/parent and the glyph class is the same as the required one by that layer, that glyph can just be inserted into the layer
@anthrotype
Copy link
Member

sounds reasonable. got a PR?

@typemytype
Copy link
Member Author

thinking about this....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@typemytype @anthrotype