Skip to content

Commit ca9d13f

Browse files
committed
Use airbnb eslint rules and disable what we don't want
1 parent 36b5e50 commit ca9d13f

File tree

4 files changed

+20
-11
lines changed

4 files changed

+20
-11
lines changed

.eslintrc

+10-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,19 @@
11
{
2-
"extends": "eslint:recommended",
2+
"extends": "airbnb",
33
"env": {
44
"browser": true,
55
"node": true,
66
"es6": true
77
},
88
"ecmaFeatures": {
9-
"modules": true,
9+
"modules": true
10+
},
11+
"rules": {
12+
"strict": 0,
13+
"no-var": 0,
14+
"no-param-reassign": 0,
15+
"prefer-arrow-callback": 0,
16+
"func-names": 0,
17+
"vars-on-top": 0
1018
}
1119
}

gulpfile.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
'use strict';
22

3-
var babelify = require("babelify");
3+
var babelify = require('babelify');
44
var browserify = require('browserify');
55
var gulp = require('gulp');
66
var source = require('vinyl-source-stream');
77
var buffer = require('vinyl-buffer');
88
var uglify = require('gulp-uglify');
99
var sourcemaps = require('gulp-sourcemaps');
1010
var gutil = require('gulp-util');
11-
var merge = require('merge-stream');
1211

1312
var browserifyConfig = {
1413
entries: './src/set-functions.js',

package.json

+4
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@
2525
"babelify": "^7.3.0",
2626
"browserify": "^13.1.1",
2727
"eslint": "^3.11.1",
28+
"eslint-config-airbnb": "^13.0.0",
29+
"eslint-plugin-import": "^2.2.0",
30+
"eslint-plugin-jsx-a11y": "^2.2.3",
31+
"eslint-plugin-react": "^6.7.1",
2832
"expect.js": "^0.3.1",
2933
"gulp": "^3.9.1",
3034
"gulp-sourcemaps": "^1.9.1",

src/set-functions.js

+5-7
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ module.exports.difference = function difference(a, b) {
8888
var result = new Set();
8989

9090
if (a) {
91-
9291
if (!b.has) {
9392
b = new Set(b);
9493
}
@@ -151,7 +150,7 @@ var BreakException = {};
151150
*
152151
* @param {Set} a
153152
* @param {Set} b
154-
* @returns {bool}
153+
* @returns {boolean}
155154
*/
156155
module.exports.isEqual = function isEqual(a, b) {
157156
'use strict';
@@ -172,24 +171,23 @@ module.exports.isEqual = function isEqual(a, b) {
172171
b = new Set(b);
173172
}
174173

175-
if (a.size != b.size) {
174+
if (a.size !== b.size) {
176175
return false;
177176
}
178177

179178
try {
180179
a.forEach(function (item) {
181180
if (!b.has(item)) {
182181
// short-circuit by throwing on first difference
183-
throw BreakException
182+
throw BreakException;
184183
}
185184
});
186185
} catch (e) {
187186
if (e === BreakException) {
188187
return false;
189-
} else {
190-
// pass on any exceptions that we didn't generate
191-
throw e;
192188
}
189+
// pass on any exceptions that we didn't generate
190+
throw e;
193191
}
194192
return true;
195193
};

0 commit comments

Comments
 (0)