Upgrade to Scala 2.13. Fix #11 #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @khatkar
This is my attempt to bring ipaddr to Scala 2.13 and fix #11.
To upgrade to Scala 2.13, I have ported
IpSetto the new collection framework, following the official guide.I also split
IpSetinto two files, one for 2.12 and earlier and one for 2.13 and later (again following the guide).I also modified other files to be compatible with the new collections (e.g.
toStream->to(LazyList)) and resolved some deprecation warnings on internal code, but not when it touched the API.I didn't modify
.travis.yml, which should be updated, as I did not know how to proceed to test that.I believe just adding
- 2.13.6underscalamight do the trick.Here are all the libs the were upgraded to be compatible with 2.13:
I hope this can be useful for the community.