Skip to content

Commit b52c909

Browse files
committed
Adding store-gw and memcached configuration to match existing datahub store path
Signed-off-by: Moad Zardab <[email protected]>
1 parent 5df6d43 commit b52c909

File tree

3 files changed

+35
-15
lines changed

3 files changed

+35
-15
lines changed

Diff for: resources/services/telemeter-prod-01/rhobs/telemeter/observatorium-metrics-store-telemeter-template.yaml

+14-14
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ objects:
8383
name: observatorium-thanos-store-bucket-cache-memcached-telemeter
8484
namespace: rhobs
8585
spec:
86-
replicas: 1
86+
replicas: 5
8787
selector:
8888
matchLabels:
8989
app.kubernetes.io/component: store-bucket-cache
@@ -135,10 +135,10 @@ objects:
135135
protocol: TCP
136136
resources:
137137
limits:
138-
memory: 3Gi
138+
memory: 12Gi
139139
requests:
140-
cpu: 500m
141-
memory: 2Gi
140+
cpu: "6"
141+
memory: 10Gi
142142
terminationMessagePolicy: FallbackToLogsOnError
143143
- args:
144144
- --memcached.address=localhost:0
@@ -240,7 +240,7 @@ objects:
240240
name: observatorium-thanos-store-index-cache-memcached-telemeter
241241
namespace: rhobs
242242
spec:
243-
replicas: 1
243+
replicas: 5
244244
selector:
245245
matchLabels:
246246
app.kubernetes.io/component: store-index-cache
@@ -292,10 +292,10 @@ objects:
292292
protocol: TCP
293293
resources:
294294
limits:
295-
memory: 3Gi
295+
memory: 12Gi
296296
requests:
297-
cpu: 500m
298-
memory: 2Gi
297+
cpu: "6"
298+
memory: 10Gi
299299
terminationMessagePolicy: FallbackToLogsOnError
300300
- args:
301301
- --memcached.address=localhost:0
@@ -517,7 +517,7 @@ objects:
517517
dns_provider_update_interval: 10s
518518
- --log.format=logfmt
519519
- --log.level=${STORE_LOG_LEVEL}
520-
- --max-time=-22h0m0s
520+
- --max-time=-336h0m0s
521521
- --objstore.config=$(OBJSTORE_CONFIG)
522522
- --selector.relabel-config-file=/etc/thanos/hashmod/hashmod-config.yaml
523523
- |
@@ -706,7 +706,7 @@ objects:
706706
- ReadWriteOnce
707707
resources:
708708
requests:
709-
storage: 5Gi
709+
storage: 50Gi
710710
storageClassName: gp2
711711
- apiVersion: monitoring.coreos.com/v1
712712
kind: ServiceMonitor
@@ -809,12 +809,12 @@ objects:
809809
observatorium/tenant: telemeter
810810
parameters:
811811
- name: STORE_CPU_REQUEST
812-
value: "2"
812+
value: "5"
813813
- name: STORE_LOG_LEVEL
814814
value: warn
815815
- name: STORE_MEMORY_LIMIT
816-
value: 20Gi
816+
value: 60Gi
817817
- name: STORE_MEMORY_REQUEST
818-
value: 5Gi
818+
value: 40Gi
819819
- name: STORE_REPLICAS
820-
value: "1"
820+
value: "5"

Diff for: services_go/instances/rhobs/rhobs.go

+19-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ import (
66
"sort"
77
"time"
88

9+
"github.com/observatorium/observatorium/configuration_go/abstr/kubernetes/memcached"
10+
thanostime "github.com/observatorium/observatorium/configuration_go/schemas/thanos/time"
11+
912
"github.com/google/go-jsonnet"
1013
observatoriumapi "github.com/observatorium/observatorium/configuration_go/abstr/kubernetes/observatorium/api"
1114
"github.com/observatorium/observatorium/configuration_go/abstr/kubernetes/thanos/receive"
@@ -331,7 +334,22 @@ func prodConfig() observatorium.Observatorium {
331334
ingestor.VolumeSize = "5Gi"
332335
},
333336
StorePreManifestsHook: func(store *store.StoreStatefulSet) {
334-
store.VolumeSize = "5Gi"
337+
store.VolumeSize = "50Gi"
338+
store.Replicas = 5
339+
store.ContainerResources = kghelpers.NewResourcesRequirements("5", "", "40Gi", "60Gi")
340+
},
341+
StoreOpts: func(opts *store.StoreOptions) {
342+
// Telemeter Lookback is -14 days (336 hours) during migration to account for an overlap with our hot telemeter instance
343+
telemeterMaxLookBack := time.Duration(-336) * time.Hour
344+
opts.MaxTime = &thanostime.TimeOrDurationValue{Dur: &telemeterMaxLookBack}
345+
},
346+
IndexCachePreManifestsHook: func(indexCache *memcached.MemcachedDeployment) {
347+
indexCache.Replicas = 5
348+
indexCache.ContainerResources = kghelpers.NewResourcesRequirements("6", "", "10Gi", "12Gi")
349+
},
350+
BucketCachePreManifestsHook: func(bucketCache *memcached.MemcachedDeployment) {
351+
bucketCache.Replicas = 5
352+
bucketCache.ContainerResources = kghelpers.NewResourcesRequirements("6", "", "10Gi", "12Gi")
335353
},
336354
},
337355
},

Diff for: services_go/observatorium/metrics.go

+2
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ type ObservatoriumMetricsInstance struct {
8888
ObjStoreSecret string
8989
Tenants []Tenants
9090
StorePreManifestsHook func(*store.StoreStatefulSet)
91+
StoreOpts func(opts *store.StoreOptions)
9192
IndexCachePreManifestsHook func(*memcached.MemcachedDeployment)
9293
BucketCachePreManifestsHook func(*memcached.MemcachedDeployment)
9394
CompactorPreManifestsHook func(*compactor.CompactorStatefulSet)
@@ -939,6 +940,7 @@ func (o *ObservatoriumMetrics) makeStore(instanceCfg *ObservatoriumMetricsInstan
939940
},
940941
}
941942
opts.AddExtraOpts("--store.enable-index-header-lazy-reader")
943+
executeIfNotNil(instanceCfg.StoreOpts, opts)
942944

943945
indexCacheName := fmt.Sprintf("observatorium-thanos-store-index-cache-memcached-%s", instanceCfg.InstanceName)
944946
bucketCacheName := fmt.Sprintf("observatorium-thanos-store-bucket-cache-memcached-%s", instanceCfg.InstanceName)

0 commit comments

Comments
 (0)