Add test cases for our CSV parser.

This does a couple of straightforward tests on our CSV parser, and then
for good measure it does two with random data - one that's just random
data, one that's had all the zeros changed to nonzero values.

Note that building and running this test does not quite work yet /on
this branch/.  In order to do that, we need some cleanups and
reorganizing that I don't want to push just yet, which can be found on
https://github.com/rhboot/shim/tree/test-reorg

Signed-off-by: Peter Jones <[email protected]>

Author: vathpela

.gitignore

@@ -28,10 +28,12 @@
 /build*/
 /certdb/
 /cov-int/
+/random.bin
 /sbat.*.csv
 /scan-results/
 [Ss]creenlog*
 shim_cert.h
-test-*
-!test-*.c
+/test-*
+!/test-*.c
+/test-random.h
 version.c

include/str.h

@@ -256,4 +256,9 @@ EFI_STATUS parse_csv_data(char *data, char *end, size_t n_columns,
                           list_t *list);
 void free_csv_list(list_t *list);
 
+#ifdef SHIM_UNIT_TEST
+void NONNULL(1, 3, 4)
+parse_csv_line(char * line, size_t max, size_t *n_columns, const char *columns[]);
+#endif
+
 #endif /* SHIM_STR_H */

include/test.mk

@@ -28,6 +28,12 @@ CFLAGS = -O2 -ggdb -std=gnu11 \
 	 -DSHIM_UNIT_TEST \
 	 "-DDEFAULT_DEBUG_PRINT_STATE=$(DEBUG_PRINTS)"
 
+$(wildcard test-*.c) :: %.c : test-random.h
+
+test-random.h:
+	dd if=/dev/urandom bs=512 count=17 of=random.bin
+	xxd -i random.bin test-random.h
+
 tests := $(patsubst %.c,%,$(wildcard test-*.c))
 
 $(tests) :: test-% : test.c test-%.c $(test-%_FILES)
@@ -36,10 +42,12 @@ $(tests) :: test-% : test.c test-%.c $(test-%_FILES)
 
 test : $(tests)
 
-all : test
-
 clean :
+	@rm -vf test-random.h random.bin
+
+all : clean test
 
 .PHONY: $(tests) all test clean
+.SECONDARY: random.bin
 
 # vim:ft=make