Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to plugin framework + features #41

Merged
merged 22 commits into from
Nov 22, 2024

Conversation

infra-monkey
Copy link
Contributor

@infra-monkey infra-monkey commented Nov 2, 2024

This pull request is a complete rewrite of the provider using the terraform plugin framework.
This PR brings a full feature parity with the current provider master branch.

The migration to the plugin framework requires go 1.22+ and terraform 1.1+.

At the same time I implemented some new features:

  • Add datasources whenever it is possible/relevant (see documentation)
  • Deprecate attributes that can be replaced by lists in membership resources. This will allow to group multiple membership attributes (users, hosts, groups etc...) into a single resource. This will reduce drastically the number of api calls made on freeipa.
  • Better resource update logic and detection of modifications made to the infrastructure outside of the terraform state.
  • Add support for freeipa v4.12. ccin2p3 being not very reactive and still on v4.6, I use my own fork that. could be move to Roman's of course.

Considering the scale of changes here, it might require to release beta releases of the provider, and obviously it requires a lot of testing.

Still missing: Migration from previous versions (based on plugin-sdkv2) require that a released version build against the latest version of ths plugin-sdk is released. Testing functions for that will have to be implemented once said release is available

Fixes #31, fixes #36

@RomanButsiy RomanButsiy marked this pull request as ready for review November 22, 2024 09:16
@RomanButsiy RomanButsiy merged commit 99eb636 into rework-space-com:main Nov 22, 2024
@jagular-spb
Copy link

awesome work!
will migrate my pipelines asap

@infra-monkey
Copy link
Contributor Author

@jagular-spb Thanks.
Remember this is beta and not field test.
If you find any problem please open an issue and specify release v5.0.0-beta.1
Any help testing this beta will be much appreciated !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ideas for next releases Any chance to get data sources
3 participants