-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to plugin framework + features #41
Merged
RomanButsiy
merged 22 commits into
rework-space-com:main
from
infra-monkey:feat/framework
Nov 22, 2024
Merged
feat: migrate to plugin framework + features #41
RomanButsiy
merged 22 commits into
rework-space-com:main
from
infra-monkey:feat/framework
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
491a812
to
f00aa20
Compare
awesome work! |
@jagular-spb Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a complete rewrite of the provider using the terraform plugin framework.
This PR brings a full feature parity with the current provider master branch.
The migration to the plugin framework requires go 1.22+ and terraform 1.1+.
At the same time I implemented some new features:
Considering the scale of changes here, it might require to release beta releases of the provider, and obviously it requires a lot of testing.
Still missing: Migration from previous versions (based on plugin-sdkv2) require that a released version build against the latest version of ths plugin-sdk is released. Testing functions for that will have to be implemented once said release is available
Fixes #31, fixes #36