Skip to content

Commit 51c90aa

Browse files
committed
Bumped minimum esp-idf version to 4.4
Hopefully will be bumped to 5.0 before the next release but right now there are remaining issues.
1 parent 0bdd415 commit 51c90aa

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

BUILDING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Building Retro-Go
22

33
## Prerequisites
4-
You will need a working installation of [esp-idf](https://docs.espressif.com/projects/esp-idf/en/release-v4.3/esp32/get-started/index.html#get-started-get-prerequisites). Versions 4.2 to 5.2 are supported.
4+
You will need a working installation of [esp-idf](https://docs.espressif.com/projects/esp-idf/en/release-v4.4/esp32/get-started/index.html#get-started-get-prerequisites). Versions 4.4 to 5.2 are supported.
55

6-
_Note: As of retro-go 1.35, I use 4.3. Version 4.1 was used for 1.20 to 1.34 versions._
6+
_Note: As of retro-go 1.44, I use 4.4.8. I used 4.3 for 1.35 to 1.43. ESP-IDF 4.1 was used for 1.20 to 1.34 versions._
77

88
### ESP-IDF Patches
99
Patching esp-idf may be required for full functionality. Patches are located in `tools/patches` and can be applied to your global esp-idf installation, they will not break your other projects/devices.

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM espressif/idf:release-v4.3
1+
FROM espressif/idf:release-v4.4
22

33
WORKDIR /app
44

components/retro-go/drivers/audio/i2s.c

-2
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,7 @@ static bool driver_init(int device, int sample_rate)
6767
if (ret == ESP_OK)
6868
{
6969
ret = i2s_set_pin(I2S_NUM_0, &(i2s_pin_config_t) {
70-
#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 4, 0)
7170
.mck_io_num = GPIO_NUM_NC,
72-
#endif
7371
.bck_io_num = RG_GPIO_SND_I2S_BCK,
7472
.ws_io_num = RG_GPIO_SND_I2S_WS,
7573
.data_out_num = RG_GPIO_SND_I2S_DATA,

components/retro-go/rg_system.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ extern "C" {
1616
#include <esp_idf_version.h>
1717
#include <esp_heap_caps.h>
1818
#include <esp_attr.h>
19-
#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(4, 3, 0)
20-
#error "Retro-Go requires ESP-IDF version 4.3.0 or newer!"
19+
#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(4, 4, 0)
20+
#error "Retro-Go requires ESP-IDF version 4.4.0 or newer!"
2121
#endif
2222
#else
2323
#define IRAM_ATTR

0 commit comments

Comments
 (0)