Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificate expiry dates do not match #2945

Open
ravenzachary opened this issue Jan 22, 2021 · 15 comments
Open

SSL certificate expiry dates do not match #2945

ravenzachary opened this issue Jan 22, 2021 · 15 comments
Assignees
Labels
bug Something isn't working

Comments

@ravenzachary
Copy link

Describe the bug
If you look at the certificate expiration date on the Let's Encrypt SSL Certificate in the browser and then compare that the certificate expiration date in the Admin > SSL section of the Wiki, the dates do not match. Currently, the Admin panel is showing an expiration date of 29 January 2021 and the browser cert details lists 22 April 20201.

To Reproduce
Steps to reproduce the behavior:

  1. Load the wiki site with SSL and view the SSL certificate expiration date in the browser.
  2. Go to the SSL section of the Admin area of your wiki and view the SSL certificate expiration date on this page.
  3. Compare them - they will not be the same.

Expected behavior
The SSL certificate expiration date should be the same.

Screenshots
Screen Shot 2021-01-22 at 10 19 23

Host Info (please complete the following information):

  • OS: Ubuntu 19.09 x64
  • Wiki.js version: 2.5.159
  • Database engine: PostgreSQL 11.5

Additional context
Add any other context about the problem here.

@cashewnuts
Copy link

cashewnuts commented Jan 29, 2021

This problem causes using up the rate limit of Let's encrypt.
If I switch wiki.js server on and off on daily basis, it will end up the error 5 days later.

https://letsencrypt.org/docs/rate-limits/

@PaulKlumpp
Copy link

I experience the same problem. It will try to update the cert far too often.

@JetForMe
Copy link

Came here to post the same screenshot :)

@dazzag24
Copy link

dazzag24 commented Jun 7, 2021

Same behavior here. Just upgraded to wiki.js version 2.5.201 and I still see the issue.
image

@rogersgt
Copy link

rogersgt commented Sep 23, 2021

@NGPixel Is there any update on this? My company's wiki site is completely down due to this, I believe. The error logs are spitting out the letsencrypt throttling error. The strange part is I haven't tried to restart the server until it was unreachable (after the throttling limit was reached). Is there at least a workaround for this?
Screen Shot 2021-09-23 at 3 49 01 PM

What I believe is happening...

  • Wiki.js thinks that the cert is expired when it's not
  • The server probably checks this on startup (?)
  • The server attempts to renew the certificate, and letsencrypt returns the 429
  • The UI is not able to load up because the server errors out

I have the following settings enabled:

  • SSL
  • SSL auto re-renew
  • HTTP -> HTTPS redirect

The server worked really well for a month, and then this. I'm unable to reach the UI via HTTP or HTTPS. I can access the database, but I'm not really sure what I should be trying to do in order to reset/get around this. Any help would be appreciated ✊

@NGPixel
Copy link
Member

NGPixel commented Sep 23, 2021

@rogersgt A simple restart of Wiki.js will trigger a certificate renewal. However it seems you exceeded the API limit so that won't work. I suggest disabling HTTPS for now (see https://docs.requarks.io/troubleshooting#how-to-manually-disable-https-ssl-redirection) and consider using a reverse proxy like Cloudflare or put an nginx instance in front.

@biji
Copy link

biji commented Oct 24, 2021

for temporary solution, you can edit letsencrypt.payload.expires in table settings

@snarum
Copy link

snarum commented Nov 17, 2021

Doen anyone know when the certificate is actually attempted renewed? to me it looks like the code is either run when the server is started, or when the Renew button is clicked in the gui. But I can't find any code that would run the certificate check regularly.

Right now my SSL page says the certificate is expired yesterday, and letsdebug.org says there is no renewal requests.

@NGPixel
Copy link
Member

NGPixel commented Nov 18, 2021

@snarum That's correct. There's no automatic renewal at the moment and yes, it needs to be added.

@jonystorm
Copy link

Hi all! I have a problem directly related to this one, I'm using versión 2.5.275, and got the email from let's encrypt my current cert only has a few days left, I have the "Renew certificate" button on the SSL admin section but the request triggered from clicking it returns an error of "Empty response", any suggestions? or anyone else having this issue?

@scott-dunt
Copy link

Suggest you restart your docker containers.. I hit that error before and restarting the containers cleared it up.

@FiretronP75
Copy link

I confirm this is still a problem. For me it seems to be showing the issued date rather than the expiration date.

@charlezkwan
Copy link

@NGPixel , any update on automatic renewal certificate feature?

@miller-coffee
Copy link

I can confirm this is still a problem with Wiki.js 2.5.300

@integrity-develop
Copy link

integrity-develop commented Mar 1, 2024

I can confirm this issue is still present in Wiki.js 2.5.301. Will this issue cause SSL requests to begin failing when the displayed date has passed? This is the first SSL I have issued for my Wiki.js deployment and I can't quite tell if this is just an issue with what is displayed in the interface or if it is an actual configuration problem that is going to manifest as failed requests. The newly issued SSL certificates display as fine in a browser. Appreciate any information someone can give me on this, and will be investigating nginx implementation in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests