Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Changes to repository without beeing forced to change the settings.yml #680

Open
lynxSven opened this issue Dec 22, 2022 · 2 comments

Comments

@lynxSven
Copy link

lynxSven commented Dec 22, 2022

New Feature

We have many repos which we want to control over one single base-settings.yml
The repos only have a settings file with a _extends:{link_to_settings}.yml so they don't change.
The only settings.yml which changes is the controlling repos base-settings.yml

The current implementation only allows to take changes into account, if the settings.yml in the many repos changes.
The index,js checks this -->

if (!settingsModified) {
      robot.log.debug(`No changes in '${Settings.FILE_NAME}' detected, returning...`)
      return
    }

app/index.js

Line 27 in 17fbd40

robot.log.debug(`No changes in '${Settings.FILE_NAME}' detected, returning...`)

We would like a behaviour or a config where we can control the repo without changing the the settings.yml
Maybe a webhook or a workflow, which allows as to do so, so we don't have to change the settings.yml just to workaround the if-condition in the index.js

@torrescd
Copy link

torrescd commented Jan 9, 2023

The lack of this feature is our only reason to not use this app instead of https://github.com/github/safe-settings

@sk31337
Copy link

sk31337 commented Aug 22, 2023

I would also love to see this change and not be forced to make a change in settings.yaml to restart the sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants