Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught type error - $safeVersion must be string #129

Closed
zswanson opened this issue May 1, 2021 · 3 comments
Closed

Uncaught type error - $safeVersion must be string #129

zswanson opened this issue May 1, 2021 · 3 comments
Assignees

Comments

@zswanson
Copy link

zswanson commented May 1, 2021

While debugging #128 I created a temporary jira group 'Developers' and assigned my jira api role to that group. Rerunning the github-security-jira [email protected] now results in a fatal error. (the action is still ignoring the actual group name I'm specifying)

Run reload/[email protected]
  env:
    GH_SECURITY_TOKEN: ***
    JIRA_TOKEN: ***
    JIRA_HOST: https://JIRA_URL
    JIRA_USER: JIRA_USER
    JIRA_PROJECT: ABC
    JIRA_ISSUE_TYPE: Bug
    JIRA_RESTRICTED_COMMENT_ROLE: JIRA_GROUP

Fatal error: Uncaught TypeError: Typed property GitHubSecurityJira\SecurityAlertIssue::$safeVersion must be string, null used in /opt/ghsec-jira/src/SecurityAlertIssue.php:41
Stack trace:
#0 /opt/ghsec-jira/src/SyncCommand.php(94): GitHubSecurityJira\SecurityAlertIssue->__construct(Array)
#1 /opt/ghsec-jira/vendor/symfony/console/Command/Command.php(255): GitHubSecurityJira\SyncCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#2 /opt/ghsec-jira/vendor/symfony/console/Application.php(1011): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#3 /opt/ghsec-jira/vendor/symfony/console/Application.php(272): Symfony\Component\Console\Application->doRunCommand(Object(GitHubSecurityJira\SyncCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#4 /opt/ghsec-jira/vendor/symfony/console/Applicat in /opt/ghsec-jira/src/SecurityAlertIssue.php on line 41
@arnested
Copy link
Member

arnested commented Jul 1, 2022

Please check if you're using the latest version. This sounds very much like what we fixed in #85.

@arnested arnested self-assigned this Jul 1, 2022
@zswanson
Copy link
Author

zswanson commented Jul 5, 2022

We eventually threw in the towel on this since I couldn't get a work around. Thought we were using the latest at the time though. I'm not at the same company anymore so I don't have a way to retest the same conditions.

@arnested
Copy link
Member

I'm going to close this now based on lack of info. You are welcome to reopen if the issue reappears or new insight is gained.

@arnested arnested closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants