Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up imports #55

Closed
calebbourg opened this issue Dec 16, 2022 · 1 comment · Fixed by #58
Closed

Clean up imports #55

calebbourg opened this issue Dec 16, 2022 · 1 comment · Fixed by #58
Assignees
Labels
enhancement Improves existing functionality or feature good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@calebbourg
Copy link
Collaborator

We should take a look at the import sections of each of our files and clean things up so that there's a consistent style.

cargo fmt does not appear to have much of an opinion.

Here is one example of a style guide

@calebbourg calebbourg added enhancement Improves existing functionality or feature good first issue Good for newcomers help wanted Extra attention is needed labels Dec 16, 2022
@calebbourg calebbourg added this to the 0.3 Release milestone Dec 16, 2022
@jhodapp
Copy link
Member

jhodapp commented Dec 19, 2022

I might also suggest that we better understand and apply the use of use vs super for our imports.

@jhodapp jhodapp moved this to Todo in ESP32-WROOM-RP Jan 4, 2023
@calebbourg calebbourg self-assigned this Jan 4, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in ESP32-WROOM-RP Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants