New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $__rate_interval instead of hardcoded time interval values when using rate() #44

Open

hcoyote opened this issue Nov 22, 2024 · 0 comments

Contributor

hcoyote commented Nov 22, 2024

https://grafana.com/blog/2020/09/28/new-in-grafana-7.2-__rate_interval-for-prometheus-rate-queries-that-just-work/

Won't link internal thread, but we tend to use hardcoded intervals now for rates, when we should probably be using $__rate_interval

This starts to break down if the time span you're viewing is smaller than the selected interval.

A quick look shows we're hardcoding 1m/5m intervals in at least this dashboard

https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Redpanda-Ops-Dashboard.json
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Connectors.json
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Kafka-Consumer-Metrics.json
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Kafka-Producer-Metrics.json
https://github.com/redpanda-data/observability/blob/main/grafana-dashboards/Kafka-Topic-Metrics.json

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment