Make default client side search dialect to 2 (#4060)

* Make default client side search dialect to 2

* Fix tests

Author: sazzad16

src/main/java/redis/clients/jedis/CommandObjects.java

@@ -53,7 +53,7 @@ protected RedisProtocol getProtocol() {
   private JedisBroadcastAndRoundRobinConfig broadcastAndRoundRobinConfig = null;
   private Lock mapperLock = new ReentrantLock(true);    
   private volatile JsonObjectMapper jsonObjectMapper;
-  private final AtomicInteger searchDialect = new AtomicInteger(0);
+  private final AtomicInteger searchDialect = new AtomicInteger(2); // DEFAULT_SEARCH_DIALECT = 2;
 
   @Experimental
   void setKeyArgumentPreProcessor(CommandKeyArgumentPreProcessor keyPreProcessor) {

src/test/java/redis/clients/jedis/modules/search/JsonSearchTest.java

@@ -122,9 +122,6 @@ public void createWithFieldNames() {
     SearchResult noFilters = client.ftSearch(index, new Query());
     assertEquals(5, noFilters.getTotalResults());
 
-    SearchResult asOriginal = client.ftSearch(index, new Query("@\\$\\.first:Jo*"));
-    assertEquals(0, asOriginal.getTotalResults());
-
     SearchResult asAttribute = client.ftSearch(index, new Query("@first:Jo*"));
     assertEquals(2, asAttribute.getTotalResults());
 

src/test/java/redis/clients/jedis/modules/search/SearchTest.java

@@ -139,9 +139,6 @@ public void createWithFieldNames() throws Exception {
     SearchResult noFilters = client.ftSearch(index, new Query());
     assertEquals(5, noFilters.getTotalResults());
 
-    SearchResult asOriginal = client.ftSearch(index, new Query("@first:Jo*"));
-    assertEquals(0, asOriginal.getTotalResults());
-
     SearchResult asAttribute = client.ftSearch(index, new Query("@given:Jo*"));
     assertEquals(2, asAttribute.getTotalResults());
 

src/test/java/redis/clients/jedis/modules/search/SearchWithParamsTest.java

@@ -147,9 +147,6 @@ public void createWithFieldNames() {
     SearchResult noFilters = client.ftSearch(index);
     assertEquals(5, noFilters.getTotalResults());
 
-    SearchResult asFirst = client.ftSearch(index, "@first:Jo*");
-    assertEquals(0, asFirst.getTotalResults());
-
     SearchResult asGiven = client.ftSearch(index, "@given:Jo*");
     assertEquals(2, asGiven.getTotalResults());