Skip to content

Commit 1698b76

Browse files
committed
Fix NPE in test clean up
1 parent a34d631 commit 1698b76

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

src/test/java/redis/clients/jedis/commands/jedis/ClusterJedisCommandsTestBase.java

+6-10
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ public void setUp() throws InterruptedException {
5858
int[] node1Slots = new int[slotsPerNode];
5959
int[] node2Slots = new int[slotsPerNode + 1];
6060
int[] node3Slots = new int[slotsPerNode];
61-
// for (int i = 0, slot1 = 0, slot2 = 0, slot3 = 0; i < JedisCluster.HASHSLOTS; i++) {
6261
for (int i = 0, slot1 = 0, slot2 = 0, slot3 = 0; i < CLUSTER_HASHSLOTS; i++) {
6362
if (i < slotsPerNode) {
6463
node1Slots[slot1++] = i;
@@ -76,28 +75,25 @@ public void setUp() throws InterruptedException {
7675
waitForClusterReady();
7776

7877
jedisClusterNode.add(new HostAndPort("127.0.0.1", 7379));
79-
// cluster = new JedisCluster(jedisClusterNode, 2000, 2000, 5, "cluster", new JedisPoolConfig());
80-
// cluster = new JedisCluster(jedisClusterNode, DefaultJedisClientConfig.builder().password("cluster").build(), 5);
8178
cluster = new JedisCluster(jedisClusterNode, null, "cluster");
82-
8379
}
8480

8581
@AfterClass
8682
public static void cleanUp() {
8783
int slotTest = JedisClusterCRC16.getSlot("test");
8884
int slot51 = JedisClusterCRC16.getSlot("51");
89-
String node3Id = getNodeId(node3.clusterNodes());
90-
node2.clusterSetSlotNode(slotTest, node3Id);
91-
node2.clusterSetSlotNode(slot51, node3Id);
92-
node2.clusterDelSlots(slotTest, slot51);
85+
if (node3 != null ) {
86+
String node3Id = getNodeId(node3.clusterNodes());
87+
node2.clusterSetSlotNode(slotTest, node3Id);
88+
node2.clusterSetSlotNode(slot51, node3Id);
89+
node2.clusterDelSlots(slotTest, slot51);
90+
}
9391
}
9492

9593
@After
9694
public void tearDown() {
9795
// clear all slots
98-
// int[] slotsToDelete = new int[JedisCluster.HASHSLOTS];
9996
int[] slotsToDelete = new int[CLUSTER_HASHSLOTS];
100-
// for (int i = 0; i < JedisCluster.HASHSLOTS; i++) {
10197
for (int i = 0; i < CLUSTER_HASHSLOTS; i++) {
10298
slotsToDelete[i] = i;
10399
}

src/test/java/redis/clients/jedis/commands/jedis/ClusterShardedPublishSubscribeCommandsTest.java

-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
import java.util.Map;
1010

1111
import io.redis.test.annotations.SinceRedisVersion;
12-
import io.redis.test.utils.RedisVersion;
13-
import io.redis.test.utils.RedisVersionRule;
14-
import org.junit.Rule;
1512
import org.junit.Test;
1613

1714
import redis.clients.jedis.BinaryJedisShardedPubSub;

0 commit comments

Comments
 (0)