Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-1.4): Fix hardcoded image for test connection pod and allow to skip the creation of this pod [RHDHBUGS-155] [RHIDP-5838] #91

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 3, 2025

Description of the change

Cherry-pick of #54

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

…e creation of this pod [RHDHBUGS-155] [RHIDP-5558] (redhat-developer#54)

* Make the test-connection pod image parameters configurable

Otherwise, this can reportedly be an issue in air-gapped environments.

* Allow to skip the creation of the test-connection pod when creating a Release

* Add some test values for CI

* Bump the Chart version

* Add docs to README template
@rm3l rm3l self-assigned this Feb 3, 2025
@rm3l rm3l requested a review from a team as a code owner February 3, 2025 15:35
Copy link

sonarqubecloud bot commented Feb 3, 2025

@rm3l rm3l changed the title fix(release-1.4): Fix hardcoded image for test connection pod and allow to skip the creation of this pod [RHDHBUGS-155] [RHIDP-5558] fix(release-1.4): Fix hardcoded image for test connection pod and allow to skip the creation of this pod [RHDHBUGS-155] [RHIDP-5838] Feb 3, 2025
@rm3l rm3l added the lgtm label Feb 3, 2025
@rm3l rm3l merged commit 5077c28 into redhat-developer:release-1.4 Feb 3, 2025
5 of 6 checks passed
@rm3l rm3l deleted the fix_release-1.4--make_test_connection_pod_image_configurable branch February 3, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant