Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-1.4): Make the dynamic plugins root PVC configurable [RHDHBUGS-156][RHIDP-5836] #90

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 3, 2025

Description of the change

Cherry-pick of #69

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

…DHBUGS-156][RHIDP-5573] (redhat-developer#69)

* Extract the dynamic plugins root PVC spec in a `dynamicPlugins.cache.volumeClaimSpec` field in the values file

This way, the whole PVC spec is configurable, including the storage
class name, along with other things like the PVC size and access modes.

* Bump the Chart version

* Extract the PostgreSQL PVC storageClass field to highlight that this configurable as well

See https://github.com/bitnami/charts/blob/postgresql/12.10.0/bitnami/postgresql/README.md#postgresql-primary-parameters

* Add test values file

* Regenerate README
@openshift-ci openshift-ci bot requested review from gazarenkov and kadel February 3, 2025 14:54
Copy link

sonarqubecloud bot commented Feb 3, 2025

@rm3l rm3l changed the title fix(release-1.4): Make the dynamic plugins root PVC storage class configurable [RHDHBUGS-156][RHIDP-5836] fix(release-1.4): Make the dynamic plugins root PVC configurable [RHDHBUGS-156][RHIDP-5836] Feb 3, 2025
@rm3l rm3l changed the title fix(release-1.4): Make the dynamic plugins root PVC configurable [RHDHBUGS-156][RHIDP-5836] fix(release-1.4): Make the dynamic plugins root PVC configurable [RHDHBUGS-156][RHIDP-5836] Feb 3, 2025
@rm3l rm3l self-assigned this Feb 3, 2025
@rm3l rm3l added the lgtm label Feb 3, 2025
@rm3l
Copy link
Member Author

rm3l commented Feb 3, 2025

Merging since this is a simple cherry-pick of #69 into release-1.4, which had already been approved.

@rm3l rm3l merged commit 6613a4a into redhat-developer:release-1.4 Feb 3, 2025
5 of 6 checks passed
@rm3l rm3l deleted the fix_release-1.4--make_dynamic_plugins_pvc_spec_configurable branch February 3, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant