Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-1.3): Use the 1.3 RHDH tag by default #86

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 3, 2025

Description of the change

'latest' might point to a newer RHDH image, which may not be compatible with the current Chart.

We can use latest in the main branch, but release branches should be using a specific tag.

Existing or Associated Issue(s)

CI issues like https://github.com/redhat-developer/rhdh-chart/actions/runs/13111723456/job/36576912437?pr=80

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@openshift-ci openshift-ci bot requested review from coreydaley and tumido February 3, 2025 11:04
@rm3l rm3l changed the title fix: Use the 1.3 RHDH tag by default fix(release-1.3): Use the 1.3 RHDH tag by default Feb 3, 2025
'latest' might point to a newer RHDH image, which may not be compatible with the current Chart.

We can use latest in the main branch, but release branches should be using a specific tag
@rm3l rm3l force-pushed the ci_use_1.3_rhdh_image_tag_by_default branch from cf99e71 to 198e94c Compare February 3, 2025 11:05
@rm3l rm3l enabled auto-merge (squash) February 3, 2025 11:05
Copy link

sonarqubecloud bot commented Feb 3, 2025

@rm3l rm3l added lgtm and removed lgtm labels Feb 3, 2025
@rm3l
Copy link
Member Author

rm3l commented Feb 3, 2025

Closing in favor of #87

@rm3l rm3l closed this Feb 3, 2025
auto-merge was automatically disabled February 3, 2025 12:07

Pull request was closed

@rm3l rm3l deleted the ci_use_1.3_rhdh_image_tag_by_default branch February 3, 2025 12:07
@rm3l rm3l restored the ci_use_1.3_rhdh_image_tag_by_default branch February 3, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant