Incorrect behavior of NewInInitializerRector

[mathieudz]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/2dc71679-38db-4a2b-be63-51889497e171

<?php

use DateTime;

final class DemoFile
{
    private DateTime $dateTime;
    
    public function __construct(?DateTime $dateTime = null)
    {
        $this->dateTime = $dateTime ?? new DateTime();
    }
}

$demo = new DemoFile(null);

Responsible rules

• NewInInitializerRector

Expected Behavior

Don't create compilation errors: the constructor cannot be called with a null parameter anymore.

[samsonasik]

I think you can simply skip the rule :)

possible improvement is we need to improve the rule to add New_ node to remove null arg when param is new initializer based on target class.

[samsonasik]

for note, make nullable doesn't make it work since the fallback is if it not have arg at all, ref

• with direct initializer with arg null: https://3v4l.org/UhLqo (not ok)
• with nullable initializer: https://3v4l.org/2Nv6S (not ok)
• with direct initializer, but without arg https://3v4l.org/kA3Os (ok)