Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for property hooks #8954

Closed
ondrejmirtes opened this issue Dec 29, 2024 · 2 comments
Closed

Support for property hooks #8954

ondrejmirtes opened this issue Dec 29, 2024 · 2 comments
Labels

Comments

@ondrejmirtes
Copy link
Contributor

Feature Request

FYI PHPStan 2.1 is going to be released in a couple of days and is going to fully support property hooks and other PHP 8.4 features.

I just posted a community update about what custom extensions and projects like Rector should do to take advantage of property hooks analysis, so make sure to read through it and plan the progress on your side 😊 phpstan/phpstan#12337

Thanks and happy new year!

@samsonasik
Copy link
Member

we handle at rector for property hook crash at PR:

If we update to PHPStan 2.1, and got virtual node unwrapped for property hook, I think we will get notified as the fixture test already exists for property hook.

Btw, it would be great if you can merge my PHPStan PR for unreachable next stmts:

included in PHPStan 2.1 so we can uses the ->getNextStatements() on unreachable statement node instead of custom visitor.

Regarding my PR for Printer crash on MethodCallableNode at PR:

Feel free to take over as I am not familiar with PHPStan printer usage on Virtual Node.

@samsonasik
Copy link
Member

Rector 2.0.5 released with support PHP-Parser 5.4.0 and PHPStan 2.1.0

https://github.com/rectorphp/rector/releases/tag/2.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants