Idea for automated fix

[OskarStark]

Just found this in the Symfony codebase.

Not sure it is already done in PHPUNIT_QUALITY Set

[TomasVotruba]

Thanks for sharing. How is useful to wide public?
Could you share PR with change from Symfony?

[OskarStark]

cc @alexandre-daubois

[alexandre-daubois]

It was detected here: https://github.com/symfony/symfony/pull/58303/files, along with some other errors. The most common in the PR is that expected and actual are reversed in some calls. I know this is a common error, this could be nice to have a Rector rule as well for this?

[OskarStark]

I know this is a common error, this could be nice to have a Rector rule as well for this?

Not sure this can be detected

[alexandre-daubois]

It was detected by PHPStorm automated tool. I think you can detect this by checking if the actual parameter is a constant of any kind, and expected is variable

[OskarStark]

Makes sense

[TomasVotruba]

Alright then!
Feel free to kick off PR 👍

rector-symfony repository seems like best target