Skip to content

Commit c736241

Browse files
SimonYansenZhaomiguelgfierroloomlikeanargyrithaiminhpv
authored
Resolve issue #2018 (#2022)
* Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to resolve #2018 Signed-off-by: Simon Zhao <[email protected]> * Exclude tensorflow versions that are not supported Signed-off-by: Simon Zhao <[email protected]> * Correct version comparison using packaging.version.Version Signed-off-by: Simon Zhao <[email protected]> * Capture importerror Signed-off-by: Simon Zhao <[email protected]> * Restrict tensorflow < 2.13 Signed-off-by: Simon Zhao <[email protected]> * Set tensorflow < 2.12 Signed-off-by: Simon Zhao <[email protected]> * Not triggering unit tests on Draft PR (#2033) * Not triggering unit tests on Draft PR Signed-off-by: Jun Ki Min <[email protected]> * Change a PR-triggering file to test Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Add missing kernelspec language Signed-off-by: Simon Zhao <[email protected]> * Remove scrapbook and papermill deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * data notebooks Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Merge multiline parameters into one line Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * [Fix] correct MIND data construction of user behavior history Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update hybrid to CF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Replace LayerRNNCell with AbstractRNNCell Signed-off-by: Simon Zhao <[email protected]> * Stop testing for deeprec Signed-off-by: Simon Zhao <[email protected]> * Refactor ranking metric `map` to be the same as Spark's (#2004) * Announcement LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update email Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * security Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * license and contribution notice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * update author link Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Add new code of conduct from LF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec to GRU Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Replacing references GRU4Rec in config files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Delete conda.md Signed-off-by: Jun Ki Min <[email protected]> * refactor map_at_k and map to be the same as Spark's Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Update readme LF feedback @wutaomsft Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update NEWS.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update README.md Co-authored-by: Andreas Argyriou <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Fix test errors, Refactor column check utils to be simpler Signed-off-by: Jun Ki Min <[email protected]> * Rename ranking tests to be _at_k suffixed Signed-off-by: Jun Ki Min <[email protected]> * Change test names in the test group Signed-off-by: Jun Ki Min <[email protected]> * add comment to mocked fn in a test Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * remove unused input Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * no need to output the logs twice Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * packages Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * skipping flaky test Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Issue with TF Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the PR gate affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Comment out the nightly builds affected tests with the upgrade to TF>2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * revert the breaking tests with TF 2.10.1 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * temporary pin to TF=2.8.4 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update security tests Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> * Update expected values to not use fixture Signed-off-by: Jun Ki Min <[email protected]> * list of test failing to fix Signed-off-by: Jun Ki Min <[email protected]> * Fix missing fixture error Signed-off-by: Jun Ki Min <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> * notebook utils programmatic execution Signed-off-by: miguelgfierro <[email protected]> * Test notebook programmatic Signed-off-by: miguelgfierro <[email protected]> * Added test notebook for utils Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> * Replace papermill and scrapbook for new internal function Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update new programmatic execution code Signed-off-by: miguelgfierro <[email protected]> * Update notebooks with new utility Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Issue with xDeepFM WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Document the tests in programmatic notebook Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Import missing store_metadata Signed-off-by: Simon Zhao <[email protected]> * Correct pattern matching and substitution Signed-off-by: Simon Zhao <[email protected]> * Increase timeout Signed-off-by: Simon Zhao <[email protected]> * Fix nightly test errors (#2045) * Revert tests tolerance * Fix notebook parameter parsing * Add notebook utils tests to test groups * Fix notebooks * Fix notebook unit tests * Update evaluation metrics name map. Handle None for exp_var * Fix smoke tests * cleanup * Fix functional test errors * make notebook parameter update function to be private * Fix benchmark notebook bug * fix remaining bugs --------- Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix benchmarks last cell to store value, not [value] Signed-off-by: Jun Ki Min <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 remove papermill and scrapbook references Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated PR template Signed-off-by: miguelgfierro <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> * Updated PR template and contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Updated contributing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> * change path hybrid Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating a jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Creating documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * WIP Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added rst files Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * license Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Weird warning with a link in the docstrings Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Fix docstring errors and replace .. note:: with Note: Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation dev Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Automatic build of documentation deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Delete workflow and try via UI Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added again the workflow Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -rf Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * git add * -f Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * add git info Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * actions to automatically update documentation 🐛 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * trying github token and pull before pushing Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * pull rebase and -Xtheirs Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * clean Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update documentation badge Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * install all deps Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * try adding other sphinx extensions Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Refact model rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * comment geoimc and rlrmc docs until issue is fixed Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * 📝 Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Adding init and other special members Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Reviewing other rst Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change sphinx version and jupyter book Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Change the way we compile the documentation Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Using the latest JB release Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Documentation working Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/requirements-doc.txt Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Update docs/_config.yml Co-authored-by: Simon Zhao <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Added comments by @SimonYansenZhao Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Upgrade versions of GitHub Actions See https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Signed-off-by: Simon Zhao <[email protected]> * Update setup.py Co-authored-by: Miguel Fierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> * Try to disable sum and sum_component only Signed-off-by: Simon Zhao <[email protected]> * Upgrade AzureML docker image Signed-off-by: Simon Zhao <[email protected]> * Correct variable names Signed-off-by: Simon Zhao <[email protected]> * Install git in the Conda env Signed-off-by: Simon Zhao <[email protected]> * Disable test_xdeepfm_component_definition Signed-off-by: Simon Zhao <[email protected]> * Use latest CUDA Signed-off-by: Simon Zhao <[email protected]> * Correct GPU selection Signed-off-by: Simon Zhao <[email protected]> * Remove leading whitespaces in Dockerfile Signed-off-by: Simon Zhao <[email protected]> * Simplify azureml-test/action.yml Signed-off-by: Simon Zhao <[email protected]> * Install wget in Docker image Signed-off-by: Simon Zhao <[email protected]> * Update Signed-off-by: Simon Zhao <[email protected]> --------- Signed-off-by: miguelgfierro <[email protected]> Signed-off-by: Simon Zhao <[email protected]> Signed-off-by: Jun Ki Min <[email protected]> Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Jun Ki Min <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: Miguel Fierro <[email protected]> Co-authored-by: thaiminhpv <[email protected]>
1 parent 4679844 commit c736241

13 files changed

+92
-88
lines changed

.github/actions/azureml-test/action.yml

+19-30
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ runs:
6969
using: "composite"
7070
steps:
7171
- name: Setup python
72-
uses: actions/setup-python@v4
72+
uses: actions/setup-python@v5
7373
with:
7474
python-version: "3.8"
7575
- name: Install azureml-core and azure-cli on a GitHub hosted server
@@ -82,43 +82,32 @@ runs:
8282
- name: Install wheel package
8383
shell: bash
8484
run: pip install --quiet wheel
85-
- name: Submit CPU tests to AzureML
85+
- name: Submit tests to AzureML
8686
shell: bash
87-
if: contains(inputs.TEST_GROUP, 'cpu')
8887
run: >-
89-
python tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py --clustername ${{inputs.CPU_CLUSTER_NAME}}
90-
--subid ${{inputs.AZUREML_TEST_SUBID}} --reponame "recommenders" --branch ${{ github.ref }}
91-
--rg ${{inputs.RG}} --wsname ${{inputs.WS}} --expname ${{inputs.EXP_NAME}}_${{inputs.TEST_GROUP}}
92-
--testlogs ${{inputs.TEST_LOGS_PATH}} --testkind ${{inputs.TEST_KIND}}
93-
--conda_pkg_python ${{inputs.PYTHON_VERSION}} --testgroup ${{inputs.TEST_GROUP}}
94-
--disable-warnings --sha "${GITHUB_SHA}"
95-
- name: Submit GPU tests to AzureML
96-
shell: bash
97-
if: contains(inputs.TEST_GROUP, 'gpu')
98-
run: >-
99-
python tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py --clustername ${{inputs.GPU_CLUSTER_NAME}}
100-
--subid ${{inputs.AZUREML_TEST_SUBID}} --reponame "recommenders" --branch ${{ github.ref }}
101-
--rg ${{inputs.RG}} --wsname ${{inputs.WS}} --expname ${{inputs.EXP_NAME}}_${{inputs.TEST_GROUP}}
102-
--testlogs ${{inputs.TEST_LOGS_PATH}} --add_gpu_dependencies --testkind ${{inputs.TEST_KIND}}
103-
--conda_pkg_python ${{inputs.PYTHON_VERSION}} --testgroup ${{inputs.TEST_GROUP}}
104-
--disable-warnings --sha "${GITHUB_SHA}"
105-
- name: Submit PySpark tests to AzureML
106-
shell: bash
107-
if: contains(inputs.TEST_GROUP, 'spark')
108-
run: >-
109-
python tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py --clustername ${{inputs.CPU_CLUSTER_NAME}}
110-
--subid ${{inputs.AZUREML_TEST_SUBID}} --reponame "recommenders" --branch ${{ github.ref }}
111-
--rg ${{inputs.RG}} --wsname ${{inputs.WS}} --expname ${{inputs.EXP_NAME}}_${{inputs.TEST_GROUP}}
112-
--testlogs ${{inputs.TEST_LOGS_PATH}} --add_spark_dependencies --testkind ${{inputs.TEST_KIND}}
113-
--conda_pkg_python ${{inputs.PYTHON_VERSION}} --testgroup ${{inputs.TEST_GROUP}}
114-
--disable-warnings --sha "${GITHUB_SHA}"
88+
python tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py \
89+
--subid ${{inputs.AZUREML_TEST_SUBID}} \
90+
--reponame "recommenders" \
91+
--branch ${{ github.ref }} \
92+
--rg ${{inputs.RG}} \
93+
--wsname ${{inputs.WS}} \
94+
--expname ${{inputs.EXP_NAME}}_${{inputs.TEST_GROUP}} \
95+
--testlogs ${{inputs.TEST_LOGS_PATH}} \
96+
--testkind ${{inputs.TEST_KIND}} \
97+
--conda_pkg_python ${{inputs.PYTHON_VERSION}} \
98+
--testgroup ${{inputs.TEST_GROUP}} \
99+
--disable-warnings \
100+
--sha "${GITHUB_SHA}" \
101+
--clustername $(if [[ ${{inputs.TEST_GROUP}} =~ "gpu" ]]; then echo "${{inputs.GPU_CLUSTER_NAME}}"; else echo "${{inputs.CPU_CLUSTER_NAME}}"; fi) \
102+
$(if [[ ${{inputs.TEST_GROUP}} =~ "gpu" ]]; then echo "--add_gpu_dependencies"; fi) \
103+
$(if [[ ${{inputs.TEST_GROUP}} =~ "spark" ]]; then echo "--add_spark_dependencies"; fi)
115104
- name: Get exit status
116105
shell: bash
117106
id: exit_status
118107
run: echo "code=$(cat ${{inputs.PYTEST_EXIT_CODE}})" >> $GITHUB_OUTPUT
119108
- name: Check Success/Failure
120109
if: ${{ steps.exit_status.outputs.code != 0 }}
121-
uses: actions/github-script@v3
110+
uses: actions/github-script@v7
122111
with:
123112
script: |
124113
core.setFailed('All tests did not pass!')

.github/workflows/azureml-cpu-nightly.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
runs-on: ubuntu-latest
4848
steps:
4949
- name: Check out repository code
50-
uses: actions/checkout@v3
50+
uses: actions/checkout@v4
5151
- name: Get test group names
5252
id: get_test_groups
5353
uses: ./.github/actions/get-test-groups
@@ -71,7 +71,7 @@ jobs:
7171
test-group: ${{ fromJSON(needs.get-test-groups.outputs.test_groups) }}
7272
steps:
7373
- name: Check out repository code
74-
uses: actions/checkout@v3
74+
uses: actions/checkout@v4
7575
- name: Execute tests
7676
uses: ./.github/actions/azureml-test
7777
id: execute_tests

.github/workflows/azureml-gpu-nightly.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
runs-on: ubuntu-latest
4848
steps:
4949
- name: Check out repository code
50-
uses: actions/checkout@v3
50+
uses: actions/checkout@v4
5151
- name: Get test group names
5252
id: get_test_groups
5353
uses: ./.github/actions/get-test-groups
@@ -71,7 +71,7 @@ jobs:
7171
test-group: ${{ fromJSON(needs.get-test-groups.outputs.test_groups) }}
7272
steps:
7373
- name: Check out repository code
74-
uses: actions/checkout@v3
74+
uses: actions/checkout@v4
7575
- name: Execute tests
7676
uses: ./.github/actions/azureml-test
7777
id: execute_tests

.github/workflows/azureml-release-pipeline.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ jobs:
3333
needs: [unit-test-workflow, cpu-nightly-workflow, gpu-nightly-workflow, spark-nightly-workflow]
3434
steps:
3535
- name: Check out repository code
36-
uses: actions/checkout@v3
36+
uses: actions/checkout@v4
3737
- name: Setup python
38-
uses: actions/setup-python@v4
38+
uses: actions/setup-python@v5
3939
with:
4040
python-version: "3.8"
4141
- name: Install wheel package

.github/workflows/azureml-spark-nightly.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
runs-on: ubuntu-latest
4747
steps:
4848
- name: Check out repository code
49-
uses: actions/checkout@v3
49+
uses: actions/checkout@v4
5050
- name: Get test group names
5151
id: get_test_groups
5252
uses: ./.github/actions/get-test-groups
@@ -70,7 +70,7 @@ jobs:
7070
test-group: ${{ fromJSON(needs.get-test-groups.outputs.test_groups) }}
7171
steps:
7272
- name: Check out repository code
73-
uses: actions/checkout@v3
73+
uses: actions/checkout@v4
7474
- name: Execute tests
7575
uses: ./.github/actions/azureml-test
7676
id: execute_tests

.github/workflows/azureml-unit-tests.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
runs-on: ubuntu-latest
3737
steps:
3838
- name: Check out repository code
39-
uses: actions/checkout@v3
39+
uses: actions/checkout@v4
4040
- name: Get test group names
4141
id: get_test_groups
4242
uses: ./.github/actions/get-test-groups
@@ -60,7 +60,7 @@ jobs:
6060
test-group: ${{ fromJSON(needs.get-test-groups.outputs.test_groups) }}
6161
steps:
6262
- name: Check out repository code
63-
uses: actions/checkout@v3
63+
uses: actions/checkout@v4
6464
- name: Execute tests
6565
uses: ./.github/actions/azureml-test
6666
id: execute_tests

.github/workflows/sarplus.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ jobs:
4141
matrix:
4242
python-version: ["3.8", "3.9"]
4343
steps:
44-
- uses: actions/checkout@v3
44+
- uses: actions/checkout@v4
4545

4646
- name: Set up Python ${{ matrix.python-version }}
47-
uses: actions/setup-python@v4
47+
uses: actions/setup-python@v5
4848
with:
4949
python-version: ${{ matrix.python-version }}
5050

@@ -96,15 +96,15 @@ jobs:
9696
- name: Upload Python wheel as GitHub artifact when merged into main
9797
# Upload the whl file of the specific python version
9898
if: github.ref == 'refs/heads/main'
99-
uses: actions/upload-artifact@v2
99+
uses: actions/upload-artifact@v4
100100
with:
101101
name: pysarplus-${{ env.sarplus_version }}-cp${{ matrix.python-version }}-wheel
102102
path: ${{ env.PYTHON_ROOT }}/dist/*.whl
103103

104104
- name: Upload Python source as GitHub artifact when merged into main
105105
# Only one pysarplus source tar file is needed
106106
if: github.ref == 'refs/heads/main' && matrix.python-version == '3.10'
107-
uses: actions/upload-artifact@v2
107+
uses: actions/upload-artifact@v4
108108
with:
109109
name: pysarplus-${{ env.sarplus_version }}-source
110110
path: ${{ env.PYTHON_ROOT }}/dist/*.tar.gz
@@ -131,7 +131,7 @@ jobs:
131131
hadoop-version: "3.3.1"
132132

133133
steps:
134-
- uses: actions/checkout@v3
134+
- uses: actions/checkout@v4
135135

136136
- name: Test
137137
run: |
@@ -180,7 +180,7 @@ jobs:
180180
181181
- name: Upload Scala bundle as GitHub artifact when merged into main
182182
if: github.ref == 'refs/heads/main'
183-
uses: actions/upload-artifact@v2
183+
uses: actions/upload-artifact@v4
184184
with:
185185
name: sarplus-${{ env.sarplus_version }}-bundle_2.12-spark-${{ matrix.spark-version }}-jar
186186
path: ${{ env.SCALA_ROOT }}/target/scala-2.12/*bundle*.jar

.github/workflows/update_documentation.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616

1717
steps:
1818
- name: Checkout repository
19-
uses: actions/checkout@v3
19+
uses: actions/checkout@v4
2020

2121
- name: Set up Python
22-
uses: actions/setup-python@v4
22+
uses: actions/setup-python@v5
2323
with:
2424
python-version: "3.10"
2525

recommenders/models/deeprec/models/sequential/rnn_cell_implement.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -601,9 +601,9 @@ def __init__(
601601
):
602602
self._build_bias = build_bias
603603

604-
if args is None or (nest.is_sequence(args) and not args):
604+
if args is None or (nest.is_nested(args) and not args):
605605
raise ValueError("`args` must be specified")
606-
if not nest.is_sequence(args):
606+
if not nest.is_nested(args):
607607
args = [args]
608608
self._is_sequence = False
609609
else:

setup.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
extras_require = {
6060
"gpu": [
6161
"nvidia-ml-py3>=7.352.0",
62-
"tensorflow==2.8.4", # FIXME: Temporarily pinned due to issue with TF version > 2.10.1 See #2018
62+
"tensorflow>=2.8.4,!=2.9.0.*,!=2.9.1,!=2.9.2,!=2.10.0.*,<3",
6363
"tf-slim>=1.1.0",
6464
"torch>=1.13.1", # for CUDA 11 support
6565
"fastai>=1.0.46,<2",
@@ -73,6 +73,7 @@
7373
"pytest>=3.6.4",
7474
"pytest-cov>=2.12.1",
7575
"pytest-mock>=3.6.1", # for access to mock fixtures in pytest
76+
"packaging>=20.9", # for version comparison in test_dependency_security.py
7677
],
7778
}
7879
# For the brave of heart

tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py

+34-22
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
"""
3838
import argparse
3939
import logging
40-
import glob
4140

4241
from azureml.core.authentication import AzureCliAuthentication
4342
from azureml.core import Workspace
@@ -146,7 +145,6 @@ def setup_persistent_compute_target(workspace, cluster_name, vm_size, max_nodes)
146145

147146
def create_run_config(
148147
cpu_cluster,
149-
docker_proc_type,
150148
add_gpu_dependencies,
151149
add_spark_dependencies,
152150
conda_pkg_jdk,
@@ -165,7 +163,6 @@ def create_run_config(
165163
the following:
166164
- Reco_cpu_test
167165
- Reco_gpu_test
168-
docker_proc_type (str) : processor type, cpu or gpu
169166
add_gpu_dependencies (bool) : True if gpu packages should be
170167
added to the conda environment, else False
171168
add_spark_dependencies (bool) : True if PySpark packages should be
@@ -179,7 +176,39 @@ def create_run_config(
179176
run_azuremlcompute = RunConfiguration()
180177
run_azuremlcompute.target = cpu_cluster
181178
run_azuremlcompute.environment.docker.enabled = True
182-
run_azuremlcompute.environment.docker.base_image = docker_proc_type
179+
if not add_gpu_dependencies:
180+
# https://github.com/Azure/AzureML-Containers/blob/master/base/cpu/openmpi4.1.0-ubuntu22.04
181+
run_azuremlcompute.environment.docker.base_image = "mcr.microsoft.com/azureml/openmpi4.1.0-ubuntu22.04"
182+
else:
183+
run_azuremlcompute.environment.docker.base_image = None
184+
# Use the latest CUDA
185+
# See
186+
# * https://learn.microsoft.com/en-us/azure/machine-learning/how-to-train-with-custom-image?view=azureml-api-1#use-a-custom-dockerfile-optional
187+
# * https://github.com/Azure/AzureML-Containers/blob/master/base/gpu/openmpi4.1.0-cuda11.8-cudnn8-ubuntu22.04
188+
run_azuremlcompute.environment.docker.base_dockerfile = r"""
189+
FROM nvcr.io/nvidia/cuda:12.3.1-devel-ubuntu22.04
190+
USER root:root
191+
ENV NVIDIA_VISIBLE_DEVICES all
192+
ENV NVIDIA_DRIVER_CAPABILITIES compute,utility
193+
ENV LANG=C.UTF-8 LC_ALL=C.UTF-8
194+
ENV DEBIAN_FRONTEND noninteractive
195+
RUN apt-get update && \
196+
apt-get install -y wget git-all && \
197+
apt-get clean -y && \
198+
rm -rf /var/lib/apt/lists/*
199+
# Conda Environment
200+
ENV MINICONDA_VERSION py38_23.3.1-0
201+
ENV PATH /opt/miniconda/bin:$PATH
202+
ENV CONDA_PACKAGE 23.5.0
203+
RUN wget -qO /tmp/miniconda.sh https://repo.anaconda.com/miniconda/Miniconda3-${MINICONDA_VERSION}-Linux-x86_64.sh && \
204+
bash /tmp/miniconda.sh -bf -p /opt/miniconda && \
205+
conda install conda=${CONDA_PACKAGE} -y && \
206+
conda update --all -c conda-forge -y && \
207+
conda clean -ay && \
208+
rm -rf /opt/miniconda/pkgs && \
209+
rm /tmp/miniconda.sh && \
210+
find / -type d -name __pycache__ | xargs rm -rf
211+
"""
183212

184213
# Use conda_dependencies.yml to create a conda environment in
185214
# the Docker image for execution
@@ -195,6 +224,7 @@ def create_run_config(
195224

196225
# install recommenders
197226
reco_extras = "dev"
227+
conda_dep.add_conda_package("anaconda::git")
198228
if add_gpu_dependencies and add_spark_dependencies:
199229
conda_dep.add_channel("conda-forge")
200230
conda_dep.add_conda_package(conda_pkg_jdk)
@@ -326,13 +356,6 @@ def create_arg_parser():
326356
default="STANDARD_D3_V2",
327357
help="Set the size of the VM either STANDARD_D3_V2",
328358
)
329-
# cpu or gpu
330-
parser.add_argument(
331-
"--dockerproc",
332-
action="store",
333-
default="cpu",
334-
help="Base image used in docker container",
335-
)
336359
# Azure subscription id, when used in a pipeline, it is stored in keyvault
337360
parser.add_argument(
338361
"--subid", action="store", default="123456", help="Azure Subscription ID"
@@ -421,16 +444,6 @@ def create_arg_parser():
421444

422445
logger = logging.getLogger("submit_groupwise_azureml_pytest.py")
423446
args = create_arg_parser()
424-
425-
if args.dockerproc == "cpu":
426-
from azureml.core.runconfig import DEFAULT_CPU_IMAGE
427-
428-
docker_proc_type = DEFAULT_CPU_IMAGE
429-
else:
430-
from azureml.core.runconfig import DEFAULT_GPU_IMAGE
431-
432-
docker_proc_type = DEFAULT_GPU_IMAGE
433-
434447
cli_auth = AzureCliAuthentication()
435448

436449
workspace = setup_workspace(
@@ -450,7 +463,6 @@ def create_arg_parser():
450463

451464
run_config = create_run_config(
452465
cpu_cluster=cpu_cluster,
453-
docker_proc_type=docker_proc_type,
454466
add_gpu_dependencies=args.add_gpu_dependencies,
455467
add_spark_dependencies=args.add_spark_dependencies,
456468
conda_pkg_jdk=args.conda_pkg_jdk,

0 commit comments

Comments
 (0)