From 8571afaee7f5054576aa48f60a974ae870d9f829 Mon Sep 17 00:00:00 2001 From: tarunrajput Date: Wed, 20 Sep 2023 14:09:56 +0530 Subject: [PATCH] address feedbacks --- .../src/tools/healthchecks/__tests__/dependencies.test.ts | 6 ++++-- packages/cli-doctor/src/tools/healthchecks/dependencies.ts | 1 - 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/cli-doctor/src/tools/healthchecks/__tests__/dependencies.test.ts b/packages/cli-doctor/src/tools/healthchecks/__tests__/dependencies.test.ts index da2a17cdd3..c332ddb781 100644 --- a/packages/cli-doctor/src/tools/healthchecks/__tests__/dependencies.test.ts +++ b/packages/cli-doctor/src/tools/healthchecks/__tests__/dependencies.test.ts @@ -36,7 +36,7 @@ describe('dependencies', () => { expect(diagnostics.needsToBeFixed).toBe(true); }); - it('returns true if dependencies contains an compatible version react native package', async () => { + it('warn if dependencies contains an compatible version of react native packages', async () => { dependenciesJSON = JSON.stringify({ name: 'AwesomeProject', dependencies: { @@ -46,6 +46,8 @@ describe('dependencies', () => { }); const diagnostics = await dependencies.getDiagnostics(environmentInfo); - expect(diagnostics.needsToBeFixed).toBe(true); + expect(diagnostics.description).toMatch( + '@react-native/codegen is part of React Native and should not be a dependency in your package.json', + ); }); }); diff --git a/packages/cli-doctor/src/tools/healthchecks/dependencies.ts b/packages/cli-doctor/src/tools/healthchecks/dependencies.ts index e915629785..7e29e0f150 100644 --- a/packages/cli-doctor/src/tools/healthchecks/dependencies.ts +++ b/packages/cli-doctor/src/tools/healthchecks/dependencies.ts @@ -27,7 +27,6 @@ const cliPackages = [ '@react-native-community/cli-tools', '@react-native-community/cli-doctor', '@react-native-community/cli-hermes', - '@react-native-community/cli-plugin-metro', '@react-native-community/cli-clean', '@react-native-community/cli-config', '@react-native-community/cli-debugger-ui',